From: David Miller <davem@davemloft.net>
To: shemminger@vyatta.com
Cc: eric.dumazet@gmail.com, gregory.v.rose@intel.com,
netdev@vger.kernel.org, bhutchings@solarflare.com
Subject: Re: [RFC V2 PATCH] rtnetlink: Add method to calculate dump info data size
Date: Mon, 09 May 2011 20:58:28 -0700 (PDT) [thread overview]
Message-ID: <20110509.205828.104070242.davem@davemloft.net> (raw)
In-Reply-To: <20110509205626.19dede92@nehalam>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Mon, 9 May 2011 20:56:26 -0700
> I was hoping that the new interface dump would not need a pre-calculated
> size and could just incrementally add values. I was trying to use an
> analogy with route dumping. The current route dump does not precalculate
> size.
Stephen the problem here is that one netdevice being dumped is highly
variable because of the VF netlink attributes.
Routes have a fixed reasonably low upper bound in size, so we always are
able to fit one route in an SKB.
Netdevices, on the other hand, can have so many VFs that one netdevice
entry does not fit even in a single 8K allocated SKB.
That's the failure case this code is trying to fix.
next prev parent reply other threads:[~2011-05-10 3:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-09 22:26 [RFC V2 PATCH] rtnetlink: Add method to calculate dump info data size Greg Rose
2011-05-09 22:45 ` Stephen Hemminger
2011-05-09 22:49 ` Rose, Gregory V
2011-05-10 2:43 ` Eric Dumazet
2011-05-10 3:17 ` Stephen Hemminger
2011-05-10 3:45 ` Eric Dumazet
2011-05-10 3:49 ` David Miller
2011-05-10 4:25 ` Rose, Gregory V
2011-05-10 3:56 ` Stephen Hemminger
2011-05-10 3:58 ` David Miller [this message]
2011-05-10 4:03 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110509.205828.104070242.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=eric.dumazet@gmail.com \
--cc=gregory.v.rose@intel.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).