From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: Valdis.Kletnieks@vt.edu, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: 2.6.39-rc6-mmotm0506 - another lockdep splat (networking this time)
Date: Mon, 09 May 2011 20:58:51 -0700 (PDT) [thread overview]
Message-ID: <20110509.205851.189693332.davem@davemloft.net> (raw)
In-Reply-To: <1304999271.3050.41.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 10 May 2011 05:47:51 +0200
> [PATCH net-next-2.6] net: fix two lockdep splats
>
> Commit e67f88dd12f6 (net: dont hold rtnl mutex during netlink dump
> callbacks) switched rtnl protection to RCU, but we forgot to adjust two
> rcu_dereference() lockdep annotations :
>
> inet_get_link_af_size() or inet_fill_link_af() might be called with
> rcu_read_lock or rtnl held, so use rcu_dereference_rtnl()
> instead of rtnl_dereference()
>
> Reported-by: Valdis Kletnieks <Valdis.Kletnieks@vt.edu>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied, thanks everyone.
next prev parent reply other threads:[~2011-05-10 3:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-10 1:05 2.6.39-rc6-mmotm0506 - another lockdep splat (networking this time) Valdis.Kletnieks
2011-05-10 2:23 ` Eric Dumazet
2011-05-10 3:47 ` Eric Dumazet
2011-05-10 3:58 ` David Miller [this message]
2011-05-10 21:48 ` Eric Dumazet
2011-05-10 21:59 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110509.205851.189693332.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Valdis.Kletnieks@vt.edu \
--cc=akpm@linux-foundation.org \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).