From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: 2.6.39-rc6-mmotm0506 - another lockdep splat (networking this time) Date: Mon, 09 May 2011 20:58:51 -0700 (PDT) Message-ID: <20110509.205851.189693332.davem@davemloft.net> References: <6954.1304989523@localhost> <1304994188.3050.17.camel@edumazet-laptop> <1304999271.3050.41.camel@edumazet-laptop> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: Valdis.Kletnieks@vt.edu, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org To: eric.dumazet@gmail.com Return-path: In-Reply-To: <1304999271.3050.41.camel@edumazet-laptop> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Eric Dumazet Date: Tue, 10 May 2011 05:47:51 +0200 > [PATCH net-next-2.6] net: fix two lockdep splats > > Commit e67f88dd12f6 (net: dont hold rtnl mutex during netlink dump > callbacks) switched rtnl protection to RCU, but we forgot to adjust two > rcu_dereference() lockdep annotations : > > inet_get_link_af_size() or inet_fill_link_af() might be called with > rcu_read_lock or rtnl held, so use rcu_dereference_rtnl() > instead of rtnl_dereference() > > Reported-by: Valdis Kletnieks > Signed-off-by: Eric Dumazet Applied, thanks everyone.