From: David Miller <davem@davemloft.net>
To: joe@perches.com
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] netdevice.h: Align struct netdevices members
Date: Thu, 12 May 2011 15:05:39 -0700 (PDT) [thread overview]
Message-ID: <20110512.150539.189697453.davem@davemloft.net> (raw)
In-Reply-To: <1305001325.19586.110.camel@Joe-Laptop>
From: Joe Perches <joe@perches.com>
Date: Mon, 09 May 2011 21:22:05 -0700
> On Tue, 2011-05-10 at 05:53 +0200, Eric Dumazet wrote:
>> Le lundi 09 mai 2011 à 20:42 -0700, Joe Perches a écrit :
>> > Save a bit of space.
>> Hmm... correct alignements are far more important for this structure.
>
> I agree. I aligned these members on "natural" boundaries.
> 4 consecutive chars rather than 2 chars, unsigned long.
>
>> Did you run benchmarks on 32bit and 64bit platforms ?
>
> Nope.
>
>> BTW we have ____cacheline_aligned_in_smp markers, I am not even sure
>> this patch saves space.
>
> That depends on whether or not CONFIG_SMP is defined and
> all of the changes are before any ____cacheline_aligned markers.
I think this is sane, Eric do you still have objections?
next prev parent reply other threads:[~2011-05-12 22:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-10 3:42 [PATCH net-next] netdevice.h: Align struct netdevices members Joe Perches
2011-05-10 3:53 ` Eric Dumazet
2011-05-10 4:22 ` Joe Perches
2011-05-12 22:05 ` David Miller [this message]
2011-05-12 23:49 ` Joe Perches
2011-05-13 17:47 ` Eric Dumazet
2011-05-13 18:07 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110512.150539.189697453.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=joe@perches.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).