netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: noahm@debian.org
Cc: shemminger@linux-foundation.org, ben@decadent.org.uk,
	625914@bugs.debian.org, bridge@lists.linux-foundation.org,
	netdev@vger.kernel.org
Subject: Re: [Bridge] Bug#625914: linux-image-2.6.38-2-amd64: bridging is not interacting well with multicast in 2.6.38-4
Date: Thu, 12 May 2011 15:59:16 -0700 (PDT)	[thread overview]
Message-ID: <20110512.155916.115945119.davem@davemloft.net> (raw)
In-Reply-To: <20110510233540.GJ6397@morgul.net>

From: Noah Meyerhans <noahm@debian.org>
Date: Tue, 10 May 2011 16:35:40 -0700

> On Tue, May 10, 2011 at 03:11:00PM -0700, Stephen Hemminger wrote:
>> There were two more follow on commits in stable related to this.
>> I recommend merging 2.6.38.6 which includes these.
> 
> The problem still exists in the current 2.6.38.6.  Backing out 5f1c356a
> still solves the problem there.
> 
> I have not yet tried anything outside the stable-2.6.38.y tree, but it
> seems like these same changes are present there, and it's unlikely that
> other releases will work any better.

So the issue is that if we back out that change, we get crashes.

Aparently there is a code path where whatever is existing in the
SKB ip options block matters, and needs to be maintained.

Someone needs to audit all of this and figure out how to fix the
problem properly.

  reply	other threads:[~2011-05-12 22:59 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20110506201234.6297.70279.reportbug@ip6-localhost>
2011-05-10  2:38 ` Bug#625914: linux-image-2.6.38-2-amd64: bridging is not interacting well with multicast in 2.6.38-4 Ben Hutchings
2011-05-10  3:15   ` Stephen Hemminger
2011-05-10  4:38   ` Noah Meyerhans
2011-05-10 12:42     ` Ben Hutchings
2011-05-10 12:55       ` Yann Dupont
2011-05-10 18:05       ` Noah Meyerhans
2011-05-10 22:11         ` [Bridge] " Stephen Hemminger
2011-05-10 23:35           ` Noah Meyerhans
2011-05-12 22:59             ` David Miller [this message]
2011-05-12 23:28               ` Stephen Hemminger
2011-05-12 23:43             ` Stephen Hemminger
2011-05-13  5:03               ` Noah Meyerhans
2011-05-13 18:03             ` Stephen Hemminger
2011-05-13 19:53             ` [PATCH] bridge: fix forwarding of IPv6 Stephen Hemminger
2011-05-13 20:00               ` Eric Dumazet
2011-05-13 20:02                 ` David Miller
2011-05-13 20:05                   ` Eric Dumazet
2011-05-13 20:24                   ` [Bridge] " Stephen Hemminger
2011-05-13 20:03               ` David Miller
2011-05-13 21:00               ` Noah Meyerhans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110512.155916.115945119.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=625914@bugs.debian.org \
    --cc=ben@decadent.org.uk \
    --cc=bridge@lists.linux-foundation.org \
    --cc=netdev@vger.kernel.org \
    --cc=noahm@debian.org \
    --cc=shemminger@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).