Re: [PATCH net-next-2.6 2/2] be2net: fix mbox polling for signal reception

[David Miller <davem@davemloft.net>]

From: Ben Hutchings <bhutchings@solarflare.com>
Date: Thu, 12 May 2011 13:49:06 +0100

> On Thu, 2011-05-12 at 11:41 +0530, Sathya Perla wrote:
>> Sending mbox cmds require multiple steps of writing to the DB register and polling
>> for an ack. Gettting interrupted in the middle by a signal breaks the mbox protocol.
>> So, set the task to UNINTERRUPTIBLE for mbox polling.
>> 
>> Signed-off-by: Sathya Perla <sathya.perla@emulex.com>
>> ---
>>  drivers/net/benet/be_cmds.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>> 
>> diff --git a/drivers/net/benet/be_cmds.c b/drivers/net/benet/be_cmds.c
>> index bff41ed..55c8301 100644
>> --- a/drivers/net/benet/be_cmds.c
>> +++ b/drivers/net/benet/be_cmds.c
>> @@ -297,7 +297,7 @@ static int be_mbox_db_ready_wait(struct be_adapter *adapter, void __iomem *db)
>>  			return -1;
>>  		}
>>  
>> -		set_current_state(TASK_INTERRUPTIBLE);
>> +		set_current_state(TASK_UNINTERRUPTIBLE);
>>  		schedule_timeout(msecs_to_jiffies(1));
> 
> msleep(1) is a lot more readable.

Agreed.

Sathya, please make this change and resubmit this patch series.

Thanks.