From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next-2.6 2/2] be2net: fix mbox polling for signal reception Date: Thu, 12 May 2011 17:29:05 -0400 (EDT) Message-ID: <20110512.172905.2288301818993183911.davem@davemloft.net> References: <1305180663-12140-1-git-send-email-sathya.perla@emulex.com> <1305204546.4065.395.camel@localhost> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: sathya.perla@emulex.com, netdev@vger.kernel.org To: bhutchings@solarflare.com Return-path: Received: from shards.monkeyblade.net ([198.137.202.13]:44095 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758663Ab1ELV3P (ORCPT ); Thu, 12 May 2011 17:29:15 -0400 In-Reply-To: <1305204546.4065.395.camel@localhost> Sender: netdev-owner@vger.kernel.org List-ID: From: Ben Hutchings Date: Thu, 12 May 2011 13:49:06 +0100 > On Thu, 2011-05-12 at 11:41 +0530, Sathya Perla wrote: >> Sending mbox cmds require multiple steps of writing to the DB register and polling >> for an ack. Gettting interrupted in the middle by a signal breaks the mbox protocol. >> So, set the task to UNINTERRUPTIBLE for mbox polling. >> >> Signed-off-by: Sathya Perla >> --- >> drivers/net/benet/be_cmds.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/net/benet/be_cmds.c b/drivers/net/benet/be_cmds.c >> index bff41ed..55c8301 100644 >> --- a/drivers/net/benet/be_cmds.c >> +++ b/drivers/net/benet/be_cmds.c >> @@ -297,7 +297,7 @@ static int be_mbox_db_ready_wait(struct be_adapter *adapter, void __iomem *db) >> return -1; >> } >> >> - set_current_state(TASK_INTERRUPTIBLE); >> + set_current_state(TASK_UNINTERRUPTIBLE); >> schedule_timeout(msecs_to_jiffies(1)); > > msleep(1) is a lot more readable. Agreed. Sathya, please make this change and resubmit this patch series. Thanks.