From: David Miller <davem@davemloft.net>
To: joe@perches.com
Cc: vladislav.yasevich@hp.com, sri@us.ibm.com,
linux-sctp@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2 v2] sctp: sctp_sendmsg: Don't initialize default_sinfo
Date: Thu, 12 May 2011 17:31:12 -0400 (EDT) [thread overview]
Message-ID: <20110512.173112.1134946518914800656.davem@davemloft.net> (raw)
In-Reply-To: <1305235641.6124.64.camel@Joe-Laptop>
From: Joe Perches <joe@perches.com>
Date: Thu, 12 May 2011 14:27:20 -0700
> This variable only needs initialization when cmsgs.info
> is NULL.
>
> Use memset to ensure padding is also zeroed so
> kernel doesn't leak any data.
>
> Signed-off-by: Joe Perches <joe@perches.com>
This looks a lot better, applied.
next prev parent reply other threads:[~2011-05-12 21:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-12 19:19 [PATCH 0/2] sctp: socket cleanups Joe Perches
2011-05-12 19:19 ` [PATCH 1/2] sctp: sctp_sendmsg: Don't initialize default_sinfo Joe Perches
2011-05-12 21:06 ` David Miller
2011-05-12 21:27 ` [PATCH 1/2 v2] " Joe Perches
2011-05-12 21:31 ` David Miller [this message]
2011-05-12 19:19 ` [PATCH 2/2] sctp: sctp_sendmsg: Don't test known non-null sinfo Joe Perches
2011-05-12 21:31 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110512.173112.1134946518914800656.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sri@us.ibm.com \
--cc=vladislav.yasevich@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).