From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: kaber@trash.net, greearb@candelatech.com, netdev@vger.kernel.org,
paulmck@linux.vnet.ibm.com
Subject: Re: [PATCH net-next-2.6] garp: remove last synchronize_rcu() call
Date: Thu, 12 May 2011 17:47:12 -0400 (EDT) [thread overview]
Message-ID: <20110512.174712.228493075378622339.davem@davemloft.net> (raw)
In-Reply-To: <1305206957.3795.21.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 12 May 2011 15:29:17 +0200
> [PATCH net-next-2.6] garp: remove last synchronize_rcu() call
>
> When removing last vlan from a device, garp_uninit_applicant() calls
> synchronize_rcu() to make sure no user can still manipulate struct
> garp_applicant before we free it.
>
> Use call_rcu() instead, as a step to further net_device dismantle
> optimizations.
>
> Add the temporary garp_cleanup_module() function to make sure no pending
> call_rcu() are left at module unload time [ this will be removed when
> kfree_rcu() is available ]
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Looks good, applied, thanks Eric.
next prev parent reply other threads:[~2011-05-12 21:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-09 13:35 [PATCH net-next-2.6] garp: remove one synchronize_rcu() call Eric Dumazet
2011-05-09 14:40 ` [PATCH net-next-2.6] vlan: remove one synchronize_net() call Eric Dumazet
2011-05-09 17:30 ` Jesse Gross
2011-05-09 18:26 ` Patrick McHardy
2011-05-09 18:42 ` David Miller
2011-05-09 18:25 ` [PATCH net-next-2.6] garp: remove one synchronize_rcu() call Patrick McHardy
2011-05-12 13:29 ` [PATCH net-next-2.6] garp: remove last " Eric Dumazet
2011-05-12 21:47 ` David Miller [this message]
2011-05-09 18:42 ` [PATCH net-next-2.6] garp: remove one " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110512.174712.228493075378622339.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=greearb@candelatech.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).