netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: mirqus@gmail.com
Cc: franco@lastsummer.de, netdev@vger.kernel.org, maheshb@google.com
Subject: Re: [PATCH RESEND net-next] ethtool: bring back missing comma in netdev features strings
Date: Thu, 12 May 2011 17:50:42 -0400 (EDT)	[thread overview]
Message-ID: <20110512.175042.1634107025552580202.davem@davemloft.net> (raw)
In-Reply-To: <BANLkTikW=vURi7sAQ9ZJdgy=JDv+JacTQQ@mail.gmail.com>

From: Michał Mirosław <mirqus@gmail.com>
Date: Thu, 12 May 2011 18:45:12 +0200

> 2011/5/12  <franco@lastsummer.de>:
>> The issue was introduced in commit eed2a12f1ed9aabf.
>>
>> Signed-off-by: Franco Fichtner <franco@lastsummer.de>
>> ---
>>  net/core/ethtool.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/net/core/ethtool.c b/net/core/ethtool.c
>> index b6f4058..b8c2b10 100644
>> --- a/net/core/ethtool.c
>> +++ b/net/core/ethtool.c
>> @@ -361,7 +361,7 @@ static const char
>> netdev_features_strings[ETHTOOL_DEV_FEATURE_WORDS * 32][ETH_GS
>>        /* NETIF_F_NTUPLE */          "rx-ntuple-filter",
>>        /* NETIF_F_RXHASH */          "rx-hashing",
>>        /* NETIF_F_RXCSUM */          "rx-checksum",
>> -       /* NETIF_F_NOCACHE_COPY */    "tx-nocache-copy"
>> +       /* NETIF_F_NOCACHE_COPY */    "tx-nocache-copy",
>>        /* NETIF_F_LOOPBACK */        "loopback",
>>  };
> 
> Acked-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>

Applied, but this patch was significantly mangled by your email
client.  Please correct this problem before submitting future
patches, as I will just push them back to you if this happens
again.

Thanks.

  parent reply	other threads:[~2011-05-12 21:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-12 16:42 [PATCH RESEND net-next] ethtool: bring back missing comma in netdev features strings franco
2011-05-12 16:45 ` Michał Mirosław
2011-05-12 17:59   ` Mahesh Bandewar
2011-05-12 21:50   ` David Miller [this message]
2011-05-12 17:58 ` Ben Hutchings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110512.175042.1634107025552580202.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=franco@lastsummer.de \
    --cc=maheshb@google.com \
    --cc=mirqus@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).