From: Rafael Aquini <aquini@linux.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: Jay Vosburgh <fubar@us.ibm.com>, Joe Perches <joe@perches.com>,
kernel-janitors@vger.kernel.org,
David Miller <davem@davemloft.net>,
Andy Gospodarek <andy@greyhouse.net>,
netdev@vger.kernel.org, Nicolas Kaiser <nikai@nikai.net>
Subject: Re: [PATCH net-next-2.6] net/bonding: adjust codingstyle for bond_3ad files
Date: Wed, 11 May 2011 21:48:41 -0300 [thread overview]
Message-ID: <20110512004839.GB2435@x61.tchesoft.com> (raw)
In-Reply-To: <20110511172814.714e2f2a@nehalam>
Howdy Stephen,
On Wed, May 11, 2011 at 05:28:14PM -0700, Stephen Hemminger wrote:
>
> This should be split into three separate patches.
>
> Always assume your change will break something for somebody and it will
> be necessary for some later investigation to bisect out the cause.
I'd like to know what are your suggestios to split it.
1. patch for comments;
2. patch for simplification (Nicolas);
3. patch for other adjusts (macro replacement, uninitialized vars...)
Would this approach really be productive?
Thanks in advance.
Cheers!
--
Rafael Aquini <aquini@linux.com>
next prev parent reply other threads:[~2011-05-12 0:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-11 22:52 [PATCH net-next-2.6] net/bonding: adjust codingstyle for bond_3ad files Rafael Aquini
2011-05-11 23:52 ` Nicolas Kaiser
2011-05-12 0:18 ` Rafael Aquini
2011-05-12 0:59 ` Joe Perches
2011-05-12 0:28 ` Stephen Hemminger
2011-05-12 0:48 ` Rafael Aquini [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-05-12 0:39 Rafael Aquini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110512004839.GB2435@x61.tchesoft.com \
--to=aquini@linux.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=fubar@us.ibm.com \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikai@nikai.net \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).