From: Stephen Hemminger <shemminger@linux-foundation.org>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
"Alexey Kuznetsov" <kuznet@ms2.inr.ac.ru>,
"Pekka Savola (ipv6)" <pekkas@netcore.fi>,
"James Morris" <jmorris@namei.org>,
"Hideaki YOSHIFUJI" <yoshfuji@linux-ipv6.org>,
"Patrick McHardy" <kaber@trash.net>,
"Eric Dumazet" <eric.dumazet@gmail.com>,
"Tom Herbert" <therbert@google.com>,
bridge@lists.linux-foundation.org
Subject: Re: [RFC PATCH v2] net: fold dev_disable_lro() into netdev_fix_features()
Date: Thu, 12 May 2011 09:57:49 -0700 [thread overview]
Message-ID: <20110512095749.016610a1@nehalam> (raw)
In-Reply-To: <1305217747.5214.17.camel@bwh-desktop>
On Thu, 12 May 2011 17:29:07 +0100
Ben Hutchings <bhutchings@solarflare.com> wrote:
> > dev->priv_flags |= IFF_BRIDGE_PORT;
> >
> > - dev_disable_lro(dev);
> > -
> > list_add_rcu(&p->list, &br->port_list);
> >
> > - netdev_update_features(br->dev);
> > + netdev_change_features(dev);
> >
> > spin_lock_bh(&br->lock);
> > changed_addr = br_stp_recalculate_bridge_id(br);
>
> Why netdev_change_features() here? I thought that was primarily for use
> when vlan_features may have been changed.
Setting IFF_BRIDGE_PORT in priv_flags causes change_features
to disable LRO.
--
next prev parent reply other threads:[~2011-05-12 16:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-07 11:48 [RFC PATCH] net: fold dev_disable_lro() into netdev_fix_features() Michał Mirosław
2011-05-09 19:08 ` David Miller
2011-05-12 16:06 ` Michał Mirosław
2011-05-12 16:06 ` [RFC PATCH v2] " Michał Mirosław
2011-05-12 16:29 ` Ben Hutchings
2011-05-12 16:35 ` Michał Mirosław
2011-05-12 16:57 ` Stephen Hemminger [this message]
2011-05-12 16:37 ` [RFC PATCH v3] " Michał Mirosław
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110512095749.016610a1@nehalam \
--to=shemminger@linux-foundation.org \
--cc=bhutchings@solarflare.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=mirq-linux@rere.qmqm.pl \
--cc=netdev@vger.kernel.org \
--cc=pekkas@netcore.fi \
--cc=therbert@google.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox