From: Jiri Pirko <jpirko@redhat.com>
To: Shan Wei <shanwei@cn.fujitsu.com>
Cc: fubar@us.ibm.com, andy@greyhouse.net,
"David Miller" <davem@davemloft.net>,
"Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
"Eric Dumazet" <eric.dumazet@gmail.com>,
ebiederm@aristanetworks.com, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] net: drivers: kill two unused macro definitions
Date: Sat, 14 May 2011 09:53:35 +0200 [thread overview]
Message-ID: <20110514075334.GA2751@psychotron> (raw)
In-Reply-To: <4DCE2A7F.1040000@cn.fujitsu.com>
Sat, May 14, 2011 at 09:08:47AM CEST, shanwei@cn.fujitsu.com wrote:
>
>
>Signed-off-by: Shan Wei <shanwei@cn.fujitsu.com>
>---
> drivers/net/bonding/bonding.h | 10 ----------
> drivers/net/veth.c | 1 -
> 2 files changed, 0 insertions(+), 11 deletions(-)
>
>diff --git a/drivers/net/bonding/bonding.h b/drivers/net/bonding/bonding.h
>index d08362e..ea1d005 100644
>--- a/drivers/net/bonding/bonding.h
>+++ b/drivers/net/bonding/bonding.h
>@@ -39,16 +39,6 @@
> netif_carrier_ok(dev))
>
> /*
>- * Checks whether bond is ready for transmit.
>- *
>- * Caller must hold bond->lock
>- */
>-#define BOND_IS_OK(bond) \
>- (((bond)->dev->flags & IFF_UP) && \
>- netif_running((bond)->dev) && \
>- ((bond)->slave_cnt > 0))
>-
>-/*
> * Checks whether slave is ready for transmit.
> */
> #define SLAVE_IS_OK(slave) \
>diff --git a/drivers/net/veth.c b/drivers/net/veth.c
>index 3b0151a..8461576 100644
>--- a/drivers/net/veth.c
>+++ b/drivers/net/veth.c
>@@ -22,7 +22,6 @@
>
> #define MIN_MTU 68 /* Min L3 MTU */
> #define MAX_MTU 65535 /* Max L3 MTU (arbitrary) */
>-#define MTU_PAD (ETH_HLEN + 4) /* Max difference between L2 and L3 size MTU */
>
> struct veth_net_stats {
> unsigned long rx_packets;
>--
>1.7.4.1
Reviewed-by: Jiri Pirko <jpirko@redhat.com>
next prev parent reply other threads:[~2011-05-14 7:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-14 7:08 [PATCH net-next] net: drivers: kill two unused macro definitions Shan Wei
2011-05-14 7:53 ` Jiri Pirko [this message]
2011-05-15 22:01 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110514075334.GA2751@psychotron \
--to=jpirko@redhat.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=ebiederm@aristanetworks.com \
--cc=eric.dumazet@gmail.com \
--cc=fubar@us.ibm.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=netdev@vger.kernel.org \
--cc=shanwei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).