From: David Miller <davem@davemloft.net>
To: linville@tuxdriver.com
Cc: wey-yi.w.guy@intel.com, linux-wireless@vger.kernel.org,
ipw3945-devel@lists.sourceforge.net, netdev@vger.kernel.org
Subject: Re: [PATCH 1/1] netlink: nla_nest_end return "unsigned init"
Date: Mon, 16 May 2011 13:51:10 -0400 (EDT) [thread overview]
Message-ID: <20110516.135110.1328027948753436190.davem@davemloft.net> (raw)
In-Reply-To: <20110516173548.GB6551@tuxdriver.com>
From: "John W. Linville" <linville@tuxdriver.com>
Date: Mon, 16 May 2011 13:35:48 -0400
> This should go to netdev@vger.kernel.org instead...
>
> On Mon, May 16, 2011 at 07:23:30AM -0700, Wey-Yi Guy wrote:
>> skb->len has unsigned int, return the correct value from nla_nest_end call.
>>
>> Signed-off-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>
Plus, the only users of the return value use it to feed "int"
return values of functions. F.e. net/core/neighbour.c's use
in neightbl_fill_parms().
I don't see this as being any better or worse, and we should
just leave the return value alone.
prev parent reply other threads:[~2011-05-16 17:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1305555810-17565-1-git-send-email-wey-yi.w.guy@intel.com>
[not found] ` <1305555810-17565-1-git-send-email-wey-yi.w.guy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2011-05-16 17:35 ` [PATCH 1/1] netlink: nla_nest_end return "unsigned init" John W. Linville
2011-05-16 17:51 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110516.135110.1328027948753436190.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ipw3945-devel@lists.sourceforge.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=wey-yi.w.guy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).