From: David Miller <davem@davemloft.net>
To: micha@neli.hopto.org
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] output ipconfig info message as one printk
Date: Mon, 16 May 2011 14:00:35 -0400 (EDT) [thread overview]
Message-ID: <20110516.140035.72516501072074389.davem@davemloft.net> (raw)
In-Reply-To: <1305409519-25404-1-git-send-email-micha@neli.hopto.org>
From: Micha Nelissen <micha@neli.hopto.org>
Date: Sat, 14 May 2011 23:45:19 +0200
> the "ip-config complete" message with ip address etc is output using
> many printks. When using the netconsole, and multiple agents are booting
> (and logging their boot) simultaneously, the syslog of the receiving
> host gets very messy, as the individual printks are interleaved.
> Combining the many printks into one printk improves syslog readability.
First, you are missing a proper "Signed-off-by: " tag in your
patch submissions.
Second, you should not do this because now the lines after the
first won't have the default loglevel prepended.
I think this should just be left alone, and you should properly
mark your netconsole logs so that you can discern which machine
the individual messages come from so you can piece them together
properly if you need to.
next prev parent reply other threads:[~2011-05-16 18:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-14 21:45 [PATCH] output ipconfig info message as one printk Micha Nelissen
2011-05-16 18:00 ` David Miller [this message]
2011-05-16 18:12 ` Micha Nelissen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110516.140035.72516501072074389.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=micha@neli.hopto.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).