From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: v13@v13.gr, netdev@vger.kernel.org
Subject: Re: [PATCH net-next-2.6 v2] ipv4: more compliant RFC 3168 support
Date: Mon, 16 May 2011 14:49:45 -0400 (EDT) [thread overview]
Message-ID: <20110516.144945.1973022094585295342.davem@davemloft.net> (raw)
In-Reply-To: <1305571057.2581.2.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Mon, 16 May 2011 20:37:37 +0200
> Commit 6623e3b24a5e (ipv4: IP defragmentation must be ECN aware) was an
> attempt to not lose "Congestion Experienced" (CE) indications when
> performing datagram defragmentation.
>
> Stefanos Harhalakis raised the point that RFC 3168 requirements were not
> completely met by this commit.
>
> In particular, we MUST detect invalid combinations and eventually drop
> illegal frames.
>
> Reported-by: Stefanos Harhalakis <v13@v13.gr>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
> ---
> v2 : Use a table instead of a switch()
Applied, thanks!
next prev parent reply other threads:[~2011-05-16 18:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201105141938.28344.v13@v13.gr>
[not found] ` <1305393402.3120.67.camel@edumazet-laptop>
[not found] ` <1305393711.3120.69.camel@edumazet-laptop>
[not found] ` <201105151337.22831.v13@v13.gr>
[not found] ` <1305461344.3120.112.camel@edumazet-laptop>
[not found] ` <1305464176.3120.113.camel@edumazet-laptop>
2011-05-15 13:35 ` [PATCH net-next-2.6] ipv4: more compliant RFC 3168 support Eric Dumazet
2011-05-15 15:08 ` Stefanos Harhalakis
2011-05-15 16:01 ` Eric Dumazet
2011-05-16 17:16 ` Eric Dumazet
2011-05-16 18:37 ` [PATCH net-next-2.6 v2] " Eric Dumazet
2011-05-16 18:49 ` David Miller [this message]
2011-05-16 19:17 ` Joe Perches
2011-05-16 21:33 ` [PATCH net-next-2.6] " Hagen Paul Pfeifer
2011-05-16 21:38 ` Eric Dumazet
2011-05-16 21:49 ` Hagen Paul Pfeifer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110516.144945.1973022094585295342.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=v13@v13.gr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).