netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: alexey.orishko@gmail.com
Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org,
	gregkh@suse.de, oliver@neukum.org, alexey.orishko@stericsson.com
Subject: Re: [PATCH] CDC NCM: release interfaces fix in unbind()
Date: Mon, 16 May 2011 15:13:02 -0400 (EDT)	[thread overview]
Message-ID: <20110516.151302.89070822321885499.davem@davemloft.net> (raw)
In-Reply-To: <1305491307-6548-1-git-send-email-alexey.orishko@stericsson.com>

From: Alexey Orishko <alexey.orishko@gmail.com>
Date: Sun, 15 May 2011 22:28:27 +0200

> Signed-off-by: Alexey Orishko <alexey.orishko@stericsson.com>

I don't know about this.

The usb_set_intfdata() calls at cdc_ncm_bind() time are unconditional,
and are performed regardless of whether ->data_claimed or
->control_claimed are set.

So conditionalizing the setting of them to NULL here doesn't seem
right at all.

I'm not applying this patch.

  reply	other threads:[~2011-05-16 19:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-15 20:28 [PATCH] CDC NCM: release interfaces fix in unbind() Alexey Orishko
2011-05-16 19:13 ` David Miller [this message]
     [not found]   ` <20110516.151302.89070822321885499.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2011-05-17  0:52     ` Alexey ORISHKO
     [not found]       ` <2AC7D4AD8BA1C640B4C60C61C8E520153E3A93E8EE-8ZTw5gFVCTjVH5byLeRTJxkTb7+GphCuwzqs5ZKRSiY@public.gmane.org>
2011-05-17  6:26         ` Oliver Neukum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110516.151302.89070822321885499.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=alexey.orishko@gmail.com \
    --cc=alexey.orishko@stericsson.com \
    --cc=gregkh@suse.de \
    --cc=linux-usb@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=oliver@neukum.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).