From: "Michael S. Tsirkin" <mst@redhat.com>
To: Herbert Xu <herbert@gondor.hengli.com.au>
Cc: "Shan Wei" <shanwei@cn.fujitsu.com>,
"Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
netdev@vger.kernel.org,
"Ben Hutchings" <bhutchings@solarflare.com>
Subject: Re: tap/bridge: Dropping NETIF_F_GSO/NETIF_F_SG
Date: Mon, 16 May 2011 12:48:21 +0300 [thread overview]
Message-ID: <20110516094821.GA9427@redhat.com> (raw)
In-Reply-To: <20110516093822.GA2779@gondor.apana.org.au>
On Mon, May 16, 2011 at 07:38:22PM +1000, Herbert Xu wrote:
> On Mon, May 16, 2011 at 11:18:41AM +0300, Michael S. Tsirkin wrote:
> >
> > There's no interface for userspace to enable it: userspace
> > only has an ioctl to enable/disable checksum offloading.
> > SG is an implementation detail.
>
> Yes there is: ethtool -K
>
> Cheers,
Ok. You are right of course, I was confused.
So it's just an info message: in the end if userspace DTRT features
get enabled properly. Functionally, there is no regression.
Both bridge and tun trigger the messages ATM. I note that
dev.c takes pains to avoid these messages:
Avoid warning from netdev_fix_features() for GSO without SG
Should all drivers do this: clear _SG if they clear checksum? What about _GSO?
If we start doing this, this spills info about flag dependencies out to drivers.
--
MST
next prev parent reply other threads:[~2011-05-16 9:48 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-04 18:18 tap/bridge: Dropping NETIF_F_GSO/NETIF_F_SG Michael S. Tsirkin
2011-05-04 22:34 ` Herbert Xu
2011-05-04 23:28 ` Michał Mirosław
2011-05-05 0:19 ` Herbert Xu
2011-05-05 8:44 ` Michael S. Tsirkin
2011-05-05 9:34 ` Shan Wei
2011-05-05 10:05 ` Herbert Xu
2011-05-16 7:32 ` Michael S. Tsirkin
2011-05-16 8:07 ` Herbert Xu
2011-05-16 8:18 ` Michael S. Tsirkin
2011-05-16 9:38 ` Herbert Xu
2011-05-16 9:48 ` Michael S. Tsirkin [this message]
2011-05-16 10:43 ` Herbert Xu
2011-05-16 11:21 ` Michael S. Tsirkin
2011-05-16 12:18 ` Herbert Xu
2011-05-16 12:24 ` Michał Mirosław
2011-05-16 22:46 ` Herbert Xu
2011-05-16 23:06 ` David Miller
2011-05-16 23:45 ` Herbert Xu
2011-05-17 5:18 ` Michael S. Tsirkin
2011-05-17 5:24 ` Herbert Xu
2011-05-17 5:48 ` Michael S. Tsirkin
2011-05-17 6:25 ` Herbert Xu
2011-05-17 8:08 ` Michał Mirosław
2011-05-17 8:15 ` Michał Mirosław
2011-05-17 8:19 ` [PATCH] net: tuntap: Fix tun_net_fix_features() Michał Mirosław
2011-05-17 14:29 ` Michael S. Tsirkin
2011-05-17 14:46 ` Michał Mirosław
2011-05-17 14:54 ` Michael S. Tsirkin
2011-05-17 15:00 ` Michał Mirosław
2011-05-17 15:11 ` Michael S. Tsirkin
2011-06-01 9:25 ` Michael S. Tsirkin
2011-06-20 19:14 ` [RESENT PATCH] " Michał Mirosław
2011-06-20 19:25 ` Ben Hutchings
2011-06-20 19:44 ` Michał Mirosław
2011-05-16 10:53 ` tap/bridge: Dropping NETIF_F_GSO/NETIF_F_SG Michał Mirosław
2011-05-16 8:28 ` Michael S. Tsirkin
2011-05-05 15:26 ` Michał Mirosław
2011-05-14 6:54 ` Shan Wei
2011-05-16 7:28 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110516094821.GA9427@redhat.com \
--to=mst@redhat.com \
--cc=bhutchings@solarflare.com \
--cc=herbert@gondor.hengli.com.au \
--cc=mirq-linux@rere.qmqm.pl \
--cc=netdev@vger.kernel.org \
--cc=shanwei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).