From: David Miller <davem@davemloft.net>
To: decot@google.com
Cc: joe@perches.com, szymon@janc.net.pl, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-net-upstream@google.com,
snanda@google.com
Subject: Re: [PATCH 2/2] forcedeth: allow to silence tx_timeout debug messages
Date: Wed, 18 May 2011 17:16:03 -0400 (EDT) [thread overview]
Message-ID: <20110518.171603.2048423328863525352.davem@davemloft.net> (raw)
In-Reply-To: <1305753000-14933-2-git-send-email-decot@google.com>
From: David Decotigny <decot@google.com>
Date: Wed, 18 May 2011 14:10:00 -0700
> From: Sameer Nanda <snanda@google.com>
>
> This change allows to silence most debug messages in case of TX
> timeout. These messages don't provide a signare/noise ratio high
> enough for production systems and, with ~30kB logged each time, they
> tend to add to a cascade effect if the system is already under stress
> (memory pressure, disk, etc.).
>
> By default, the debug messages are not displayed but this can be
> overriden by setting the debug_tx_timeout module parameter.
>
>
> Signed-off-by: David Decotigny <decot@google.com>
I would rather you make the messages less verbose, instead of
having it say absolutely nothing when this happens as it is
a serious problem.
You can add a knob which when enabled gives the old verbosity
back for diagnostic purposes.
next prev parent reply other threads:[~2011-05-18 21:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-18 21:09 [PATCH 1/2] forcedeth: make module parameters readable in /sys/module David Decotigny
2011-05-18 21:10 ` [PATCH 2/2] forcedeth: allow to silence tx_timeout debug messages David Decotigny
2011-05-18 21:16 ` David Miller [this message]
2011-05-18 21:43 ` David Decotigny
2011-05-18 22:01 ` David Miller
2011-05-18 22:03 ` [PATCH 1/2] forcedeth: make module parameters readable in /sys/module Stephen Hemminger
2011-05-18 23:21 ` David Decotigny
2011-05-19 3:09 ` Bill Fink
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110518.171603.2048423328863525352.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=decot@google.com \
--cc=joe@perches.com \
--cc=kernel-net-upstream@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=snanda@google.com \
--cc=szymon@janc.net.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).