From: David Miller <davem@davemloft.net>
To: dennis.aberilla@mimomax.com
Cc: info@mocean-labs.com, netdev@vger.kernel.org
Subject: Re: [PATCH] drivers/net: ks8842 Fix crash on received packet when in PIO mode.
Date: Thu, 19 May 2011 16:12:28 -0400 (EDT) [thread overview]
Message-ID: <20110519.161228.1163475688237712245.davem@davemloft.net> (raw)
In-Reply-To: <20110518225945.GB6416@dens-work>
From: Dennis Aberilla <dennis.aberilla@mimomax.com>
Date: Thu, 19 May 2011 10:59:47 +1200
> This patch fixes a kernel crash during packet reception due to not
> enough allocated bytes for the skb. This applies to the driver when
> running in PIO mode in an ISA bus setup.
>
> Signed-off-by: Dennis Aberilla <denzzzhome@yahoo.com>
If you're trying to accomodate the fact that the loops iterate
always by 2 or 4 bytes at a time, then you will need to allocate
up to "3" bytes of slack space, not just "2".
You need to describe exactly what the precise problem is in your
commit message, or else people might find it difficult to figure
out exactly what the problem is.
next prev parent reply other threads:[~2011-05-19 20:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-18 22:59 [PATCH] drivers/net: ks8842 Fix crash on received packet when in PIO mode Dennis Aberilla
2011-05-19 20:12 ` David Miller [this message]
2011-05-19 23:30 ` Dennis Aberilla
-- strict thread matches above, loose matches on Subject: below --
2011-05-29 21:46 Dennis Aberilla
2011-05-31 22:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110519.161228.1163475688237712245.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dennis.aberilla@mimomax.com \
--cc=info@mocean-labs.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).