* Re: [PATCH] ehea: Fix multicast registration on semi-promiscuous mode [not found] <1305920934-7316-1-git-send-email-leitao@linux.ibm.com> @ 2011-05-20 20:28 ` David Miller 2011-05-23 13:36 ` leitao 0 siblings, 1 reply; 3+ messages in thread From: David Miller @ 2011-05-20 20:28 UTC (permalink / raw) To: leitao; +Cc: netdev, leitao This patch only made it to me privately and did not make it to the mailing list, please sort this out so that the patch can be reviewed by people other than me. ^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] ehea: Fix multicast registration on semi-promiscuous mode 2011-05-20 20:28 ` [PATCH] ehea: Fix multicast registration on semi-promiscuous mode David Miller @ 2011-05-23 13:36 ` leitao 2011-05-23 20:34 ` David Miller 0 siblings, 1 reply; 3+ messages in thread From: leitao @ 2011-05-23 13:36 UTC (permalink / raw) To: davem; +Cc: netdev, Breno Leitao Ehea will not register multicast groups in phyp if the physical interface is in promiscuous mode. But it should register if the logical port is in promiscuous mode, but the physical port is not. Ehea physical promiscuous mode is defined by ehea_port->promisc, while logical port is defined by IFF_PROMISC. So currently, if the user set the interface in promiscuous mode, IGMP will not be registred in PHYP, and PHYP will never pass the multicast packet to the logical port, which is bad So, this patch just fixes it, assuring that we register in phyp if the physical port is not on promiscuous mode. Signed-off-by: Breno Leitao <leitao@linux.vnet.ibm.com> --- drivers/net/ehea/ehea_main.c | 2 +- drivers/tty/serial/8250.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ehea/ehea_main.c b/drivers/net/ehea/ehea_main.c index cf79cf7..80027be 100644 --- a/drivers/net/ehea/ehea_main.c +++ b/drivers/net/ehea/ehea_main.c @@ -2082,7 +2082,7 @@ static void ehea_set_multicast_list(struct net_device *dev) struct netdev_hw_addr *ha; int ret; - if (dev->flags & IFF_PROMISC) { + if (port->promisc) { ehea_promiscuous(dev, 1); return; } -- 1.7.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ehea: Fix multicast registration on semi-promiscuous mode 2011-05-23 13:36 ` leitao @ 2011-05-23 20:34 ` David Miller 0 siblings, 0 replies; 3+ messages in thread From: David Miller @ 2011-05-23 20:34 UTC (permalink / raw) To: leitao; +Cc: netdev From: leitao@linux.vnet.ibm.com Date: Mon, 23 May 2011 10:36:35 -0300 > Ehea will not register multicast groups in phyp if the physical > interface is in promiscuous mode. But it should register if the > logical port is in promiscuous mode, but the physical port is not. > > Ehea physical promiscuous mode is defined by ehea_port->promisc, > while logical port is defined by IFF_PROMISC. > > So currently, if the user set the interface in promiscuous mode, > IGMP will not be registred in PHYP, and PHYP will never pass > the multicast packet to the logical port, which is bad > > So, this patch just fixes it, assuring that we register in phyp > if the physical port is not on promiscuous mode. > > Signed-off-by: Breno Leitao <leitao@linux.vnet.ibm.com> Applied, thanks. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-05-23 20:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1305920934-7316-1-git-send-email-leitao@linux.ibm.com>
2011-05-20 20:28 ` [PATCH] ehea: Fix multicast registration on semi-promiscuous mode David Miller
2011-05-23 13:36 ` leitao
2011-05-23 20:34 ` David Miller
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).