netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@vyatta.com>
To: netdev@vger.kernel.org, David Miller <davem@davemloft.net>
Subject: [PATCH] netdev: stop Features changed message
Date: Fri, 20 May 2011 09:02:08 -0700	[thread overview]
Message-ID: <20110520090208.7709bec3@nehalam> (raw)

The new in 2.6.39 message "Features changed:" occurs a lot
on many configurations. It provides information to driver developers
but is not user friendly. Printing out hex values is just confusing.
Reduce priority so that it doesn't show up unless debugging.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>

--- a/net/core/dev.c	2011-05-20 08:59:40.248885114 -0700
+++ b/net/core/dev.c	2011-05-20 09:00:32.925437770 -0700
@@ -5258,7 +5258,7 @@ void netdev_update_features(struct net_d
 	if (dev->features == features)
 		return;
 
-	netdev_info(dev, "Features changed: 0x%08x -> 0x%08x\n",
+	netdev_dbg(dev, "Features changed: 0x%08x -> 0x%08x\n",
 		dev->features, features);
 
 	if (dev->netdev_ops->ndo_set_features)

             reply	other threads:[~2011-05-20 16:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-20 16:02 Stephen Hemminger [this message]
2011-05-20 16:21 ` [PATCH] netdev: stop Features changed message Michał Mirosław
2011-05-20 18:26 ` David Miller
2011-05-20 18:31   ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110520090208.7709bec3@nehalam \
    --to=shemminger@vyatta.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).