* [PATCH] netdev: stop Features changed message
@ 2011-05-20 16:02 Stephen Hemminger
2011-05-20 16:21 ` Michał Mirosław
2011-05-20 18:26 ` David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Stephen Hemminger @ 2011-05-20 16:02 UTC (permalink / raw)
To: netdev, David Miller
The new in 2.6.39 message "Features changed:" occurs a lot
on many configurations. It provides information to driver developers
but is not user friendly. Printing out hex values is just confusing.
Reduce priority so that it doesn't show up unless debugging.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
--- a/net/core/dev.c 2011-05-20 08:59:40.248885114 -0700
+++ b/net/core/dev.c 2011-05-20 09:00:32.925437770 -0700
@@ -5258,7 +5258,7 @@ void netdev_update_features(struct net_d
if (dev->features == features)
return;
- netdev_info(dev, "Features changed: 0x%08x -> 0x%08x\n",
+ netdev_dbg(dev, "Features changed: 0x%08x -> 0x%08x\n",
dev->features, features);
if (dev->netdev_ops->ndo_set_features)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] netdev: stop Features changed message
2011-05-20 16:02 [PATCH] netdev: stop Features changed message Stephen Hemminger
@ 2011-05-20 16:21 ` Michał Mirosław
2011-05-20 18:26 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: Michał Mirosław @ 2011-05-20 16:21 UTC (permalink / raw)
To: David Miller; +Cc: netdev, Stephen Hemminger
2011/5/20 Stephen Hemminger <shemminger@vyatta.com>:
> The new in 2.6.39 message "Features changed:" occurs a lot
> on many configurations. It provides information to driver developers
> but is not user friendly. Printing out hex values is just confusing.
> Reduce priority so that it doesn't show up unless debugging.
The same patch is already in net-next:
604ae14ffb6d75d6eef4757859226b758d6bf9e3. Wasn't it meat for
net/stable back then?
Best Regards,
Michał Mirosław
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] netdev: stop Features changed message
2011-05-20 16:02 [PATCH] netdev: stop Features changed message Stephen Hemminger
2011-05-20 16:21 ` Michał Mirosław
@ 2011-05-20 18:26 ` David Miller
2011-05-20 18:31 ` Stephen Hemminger
1 sibling, 1 reply; 4+ messages in thread
From: David Miller @ 2011-05-20 18:26 UTC (permalink / raw)
To: shemminger; +Cc: netdev
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Fri, 20 May 2011 09:02:08 -0700
> The new in 2.6.39 message "Features changed:" occurs a lot
> on many configurations. It provides information to driver developers
> but is not user friendly. Printing out hex values is just confusing.
> Reduce priority so that it doesn't show up unless debugging.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
THis was already in net-2.6 and is queued up for 2.6.39-stable
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] netdev: stop Features changed message
2011-05-20 18:26 ` David Miller
@ 2011-05-20 18:31 ` Stephen Hemminger
0 siblings, 0 replies; 4+ messages in thread
From: Stephen Hemminger @ 2011-05-20 18:31 UTC (permalink / raw)
To: David Miller; +Cc: netdev
On Fri, 20 May 2011 14:26:50 -0400 (EDT)
David Miller <davem@davemloft.net> wrote:
> From: Stephen Hemminger <shemminger@vyatta.com>
> Date: Fri, 20 May 2011 09:02:08 -0700
>
> > The new in 2.6.39 message "Features changed:" occurs a lot
> > on many configurations. It provides information to driver developers
> > but is not user friendly. Printing out hex values is just confusing.
> > Reduce priority so that it doesn't show up unless debugging.
> >
> > Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
>
> THis was already in net-2.6 and is queued up for 2.6.39-stable
ok.
--
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-05-20 18:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-20 16:02 [PATCH] netdev: stop Features changed message Stephen Hemminger
2011-05-20 16:21 ` Michał Mirosław
2011-05-20 18:26 ` David Miller
2011-05-20 18:31 ` Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).