From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [patch net-next-2.6 v2] net: vlan: make non-hw-accel rx path similar to hw-accel Date: Sun, 22 May 2011 08:29:16 +0200 Message-ID: <20110522062915.GA2611@jirka.orion> References: <1302241713-3637-1-git-send-email-jpirko@redhat.com> <20110412.141645.112604563.davem@davemloft.net> <20110521072925.GA2588@jirka.orion> <4DD7BB61.9050200@gmail.com> <4DD87C25.4030701@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jesse Gross , Changli Gao , David Miller , netdev@vger.kernel.org, shemminger@linux-foundation.org, kaber@trash.net, fubar@us.ibm.com, eric.dumazet@gmail.com, andy@greyhouse.net, ebiederm@xmission.com To: Nicolas de =?iso-8859-1?Q?Peslo=FCan?= Return-path: Received: from mx1.redhat.com ([209.132.183.28]:52262 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751380Ab1EVG3i (ORCPT ); Sun, 22 May 2011 02:29:38 -0400 Content-Disposition: inline In-Reply-To: <4DD87C25.4030701@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: Sun, May 22, 2011 at 04:59:49AM CEST, nicolas.2p.debian@gmail.com wrote: > >And because some setups may still require the skb not to be untagged, >may be we need the ability to re-tag the skb in some situations... >When a protocol handler or rx_handler is explicitly registered on a >net_device which expect to receive tagged skb, we should deliver >tagged skb to it... Arguably, this may sound incredible for the >general case, but may be required for not-so-special cases like >bridge or protocol analyzer. Wait, what setups/code require the skb not to be untagged? If there's such, it should be fixed.