From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [patch net-next-2.6 v2] net: vlan: make non-hw-accel rx path similar to hw-accel Date: Sun, 22 May 2011 15:16:31 +0200 Message-ID: <20110522131630.GA3156@jirka.orion> References: <20110521072925.GA2588@jirka.orion> <4DD7BB61.9050200@gmail.com> <4DD87C25.4030701@gmail.com> <20110522062915.GA2611@jirka.orion> <20110522093758.GC2611@jirka.orion> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Nicolas de =?iso-8859-1?Q?Peslo=FCan?= , Jesse Gross , David Miller , netdev@vger.kernel.org, shemminger@linux-foundation.org, kaber@trash.net, fubar@us.ibm.com, eric.dumazet@gmail.com, andy@greyhouse.net, ebiederm@xmission.com To: Changli Gao Return-path: Received: from mx1.redhat.com ([209.132.183.28]:45748 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752954Ab1EVNRA (ORCPT ); Sun, 22 May 2011 09:17:00 -0400 Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: > >I know the current software emulation doesn't strip the vlan headers, >but I want to know in what way you fix the current misuse of >vlan_check_reorder_header(). If you emulation what the HW does >exactly, I am afraid more work are needed. IMHO, this way is more >dangerous than just a revert for this bugfix cycle. Looking at this. Will follow-up soon. > >-- >Regards, >Changli Gao(xiaosuo@gmail.com)