From: Vasiliy Kulikov <segoon@openwall.com>
To: Pavel Kankovsky <peak@argo.troja.mff.cuni.cz>
Cc: Alexey Dobriyan <adobriyan@gmail.com>,
netdev@vger.kernel.org, Solar Designer <solar@openwall.com>
Subject: Re: [PATCH] net: ipv4: add IPPROTO_ICMP socket kind
Date: Sun, 22 May 2011 21:46:32 +0400 [thread overview]
Message-ID: <20110522174632.GA4388@albatros> (raw)
In-Reply-To: <20110522174412.2F0C.0@paddy.troja.mff.cuni.cz>
On Sun, May 22, 2011 at 18:01 +0200, Pavel Kankovsky wrote:
> On Thu, 14 Apr 2011, Alexey Dobriyan wrote:
>
> > Also, there was big discussion re exposing kernel socket pointers,
> > which this file continue to do.
>
> One late comment:
>
> The code was intented to immitate /proc/net/udp.
>
> As far as I can tell UDP and TCP (having checked udp.c and tcp_ipv[46].c
> in the latest net-next-2.6) do not have any qualms about exposing kernel
> pointers so we are a little bit holier than the pope here. :)
Anyway, ping uses %pK:
seq_printf(f, "%5d: %08X:%04X %08X:%04X"
" %02X %08X:%08X %02X:%08lX %08X %5d %8d %lu %d %pK d%n",
bucket, src, srcp, dest, destp, sp->sk_state,
sk_wmem_alloc_get(sp),
sk_rmem_alloc_get(sp),
0, 0L, 0, sock_i_uid(sp), 0, sock_i_ino(sp),
atomic_read(&sp->sk_refcnt), sp,
atomic_read(&sp->sk_drops), len);
Thanks,
--
Vasiliy Kulikov
http://www.openwall.com - bringing security into open computing environments
next prev parent reply other threads:[~2011-05-22 17:46 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-09 10:15 [PATCH] net: ipv4: add IPPROTO_ICMP socket kind Vasiliy Kulikov
2011-04-12 5:06 ` Solar Designer
2011-04-12 21:25 ` David Miller
2011-04-13 11:22 ` Vasiliy Kulikov
2011-05-05 11:32 ` Vasiliy Kulikov
2011-05-10 18:09 ` [PATCH v2] " Vasiliy Kulikov
2011-05-10 19:15 ` David Miller
2011-05-10 19:45 ` Vasiliy Kulikov
2011-05-13 20:01 ` [PATCH v3] " Vasiliy Kulikov
2011-05-13 20:08 ` David Miller
2011-05-13 21:30 ` Andi Kleen
[not found] ` <m2wrhuxp8c.fsf-Vw/NltI1exuRpAAqCnN02g@public.gmane.org>
2011-05-13 22:22 ` [PATCH net-next-2.6] net: ipv4: add ping_group_range documentation Eric Dumazet
2011-05-15 8:18 ` [PATCH net-next-2.6] net: ping: dont call udp_ioctl() Eric Dumazet
2011-05-15 21:30 ` Solar Designer
2011-05-15 21:44 ` David Miller
2011-05-16 7:26 ` [PATCH net-next-2.6 v2] " Eric Dumazet
2011-05-16 12:48 ` Vasiliy Kulikov
2011-05-16 15:50 ` David Miller
2011-04-13 10:29 ` [PATCH] net: ipv4: add IPPROTO_ICMP socket kind Alexey Dobriyan
2011-04-13 11:32 ` Vasiliy Kulikov
2011-04-14 9:16 ` Alexey Dobriyan
2011-05-22 16:01 ` Pavel Kankovsky
2011-05-22 17:46 ` Vasiliy Kulikov [this message]
2011-04-14 1:53 ` Simon Horman
-- strict thread matches above, loose matches on Subject: below --
2011-03-18 18:00 Vasiliy Kulikov
2011-03-18 19:47 ` David Miller
2011-03-18 19:59 ` Vasiliy Kulikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110522174632.GA4388@albatros \
--to=segoon@openwall.com \
--cc=adobriyan@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peak@argo.troja.mff.cuni.cz \
--cc=solar@openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).