From: David Miller <davem@davemloft.net>
To: sathya.perla@emulex.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] be2net: hash key for rss-config cmd not set
Date: Mon, 23 May 2011 15:52:06 -0400 (EDT) [thread overview]
Message-ID: <20110523.155206.345121915872826257.davem@davemloft.net> (raw)
In-Reply-To: <249a7eac-6aa7-481d-b7b0-a2a3b144963f@exht1.ad.emulex.com>
From: Sathya Perla <sathya.perla@emulex.com>
Date: Mon, 23 May 2011 17:55:27 +0530
> Need a random hash key to effectively hash incoming connections into
> multiple RX rings.
>
> Signed-off-by: Sathya Perla <sathya.perla@emulex.com>
You're saying you need a random hash key, yet you're assigning
a constant.
Why not use a real random number, via get_random() or similar?
next prev parent reply other threads:[~2011-05-23 19:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-23 12:25 [PATCH] be2net: hash key for rss-config cmd not set Sathya Perla
2011-05-23 15:48 ` Ben Hutchings
2011-05-23 19:52 ` David Miller [this message]
2011-05-24 5:46 ` Sathya.Perla
2011-05-24 6:22 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2011-05-24 6:29 Sathya Perla
2011-05-24 13:12 ` Flavio Leitner
2011-05-24 17:34 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110523.155206.345121915872826257.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sathya.perla@emulex.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).