From: David Miller <davem@davemloft.net>
To: leitao@linux.vnet.ibm.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] ehea: Fix multicast registration on semi-promiscuous mode
Date: Mon, 23 May 2011 16:34:23 -0400 (EDT) [thread overview]
Message-ID: <20110523.163423.238991063346962299.davem@davemloft.net> (raw)
In-Reply-To: <1306157795-13377-1-git-send-email-leitao@linux.vnet.ibm.com>
From: leitao@linux.vnet.ibm.com
Date: Mon, 23 May 2011 10:36:35 -0300
> Ehea will not register multicast groups in phyp if the physical
> interface is in promiscuous mode. But it should register if the
> logical port is in promiscuous mode, but the physical port is not.
>
> Ehea physical promiscuous mode is defined by ehea_port->promisc,
> while logical port is defined by IFF_PROMISC.
>
> So currently, if the user set the interface in promiscuous mode,
> IGMP will not be registred in PHYP, and PHYP will never pass
> the multicast packet to the logical port, which is bad
>
> So, this patch just fixes it, assuring that we register in phyp
> if the physical port is not on promiscuous mode.
>
> Signed-off-by: Breno Leitao <leitao@linux.vnet.ibm.com>
Applied, thanks.
prev parent reply other threads:[~2011-05-23 20:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1305920934-7316-1-git-send-email-leitao@linux.ibm.com>
2011-05-20 20:28 ` [PATCH] ehea: Fix multicast registration on semi-promiscuous mode David Miller
2011-05-23 13:36 ` leitao
2011-05-23 20:34 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110523.163423.238991063346962299.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=leitao@linux.vnet.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).