From: Vasiliy Kulikov <segoon@openwall.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] net: ping: cleanups ping_v4_unhash()
Date: Mon, 23 May 2011 12:43:08 +0400 [thread overview]
Message-ID: <20110523084308.GA6244@albatros> (raw)
In-Reply-To: <1306138981.2869.2.camel@edumazet-laptop>
On Mon, May 23, 2011 at 10:23 +0200, Eric Dumazet wrote:
> net/ipv4/ping.c: In function ‘ping_v4_unhash’:
> net/ipv4/ping.c:140:28: warning: variable ‘hslot’ set but not used
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Acked-by: Vasiliy Kulikov <segoon@openwall.com>
hslot was used for debugging purposes here.
BTW, what gcc version do you use? I have no warning with 4.4.3
(Ubuntu 4.4.3-4ubuntu5):
$ make net/ipv4/ping.o
CHK include/linux/version.h
CHK include/generated/utsrelease.h
CALL scripts/checksyscalls.sh
CC net/ipv4/ping.o
$
Thanks,
--
Vasiliy Kulikov
http://www.openwall.com - bringing security into open computing environments
next prev parent reply other threads:[~2011-05-23 8:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-23 8:23 [PATCH] net: ping: cleanups ping_v4_unhash() Eric Dumazet
2011-05-23 8:43 ` Vasiliy Kulikov [this message]
2011-05-23 9:00 ` Eric Dumazet
2011-05-23 20:29 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110523084308.GA6244@albatros \
--to=segoon@openwall.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox