* [PATCH] sctp: fixed missing fixup of sctp_local_addr_free
@ 2011-05-27 17:37 Neil Horman
2011-05-27 17:40 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Neil Horman @ 2011-05-27 17:37 UTC (permalink / raw)
To: netdev
Cc: Neil Horman, Vlad Yasevich, Sridhar Samudrala, David S. Miller,
linux-sctp
commit 1231f0baa547a541a7481119323b7f964dda4788 Converted sctp to use
kfree_rcu from sctp_local_addr_free but missed this one call point. Fix it up
accordingly.
Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
CC: Vlad Yasevich <vladislav.yasevich@hp.com>
CC: Sridhar Samudrala <sri@us.ibm.com>
CC: "David S. Miller" <davem@davemloft.net>
CC: linux-sctp@vger.kernel.org
---
net/sctp/bind_addr.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/sctp/bind_addr.c b/net/sctp/bind_addr.c
index 6338413..83e3011 100644
--- a/net/sctp/bind_addr.c
+++ b/net/sctp/bind_addr.c
@@ -145,7 +145,7 @@ static void sctp_bind_addr_clean(struct sctp_bind_addr *bp)
/* Empty the bind address list. */
list_for_each_entry_safe(addr, temp, &bp->address_list, list) {
list_del_rcu(&addr->list);
- call_rcu(&addr->rcu, sctp_local_addr_free);
+ kfree_rcu(addr, rcu);
SCTP_DBG_OBJCNT_DEC(addr);
}
}
--
1.7.5.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] sctp: fixed missing fixup of sctp_local_addr_free
2011-05-27 17:37 [PATCH] sctp: fixed missing fixup of sctp_local_addr_free Neil Horman
@ 2011-05-27 17:40 ` David Miller
2011-05-27 17:42 ` Neil Horman
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2011-05-27 17:40 UTC (permalink / raw)
To: nhorman; +Cc: netdev, vladislav.yasevich, sri, linux-sctp
From: Neil Horman <nhorman@tuxdriver.com>
Date: Fri, 27 May 2011 13:37:00 -0400
> commit 1231f0baa547a541a7481119323b7f964dda4788 Converted sctp to use
> kfree_rcu from sctp_local_addr_free but missed this one call point. Fix it up
> accordingly.
>
> Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
This has been fixed for several days now.
If you're using the net-next-2.6 tree, don't, when it's not active
it's just a dummy tree for Stephen Rothwell to pull into -next
and it will be rebuilt as soon as the merge window is over.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] sctp: fixed missing fixup of sctp_local_addr_free
2011-05-27 17:40 ` David Miller
@ 2011-05-27 17:42 ` Neil Horman
0 siblings, 0 replies; 3+ messages in thread
From: Neil Horman @ 2011-05-27 17:42 UTC (permalink / raw)
To: David Miller; +Cc: netdev, vladislav.yasevich, sri, linux-sctp
On Fri, May 27, 2011 at 01:40:04PM -0400, David Miller wrote:
> From: Neil Horman <nhorman@tuxdriver.com>
> Date: Fri, 27 May 2011 13:37:00 -0400
>
> > commit 1231f0baa547a541a7481119323b7f964dda4788 Converted sctp to use
> > kfree_rcu from sctp_local_addr_free but missed this one call point. Fix it up
> > accordingly.
> >
> > Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
>
> This has been fixed for several days now.
>
> If you're using the net-next-2.6 tree, don't, when it's not active
> it's just a dummy tree for Stephen Rothwell to pull into -next
> and it will be rebuilt as soon as the merge window is over.
>
Ok, copy that, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-05-27 17:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-27 17:37 [PATCH] sctp: fixed missing fixup of sctp_local_addr_free Neil Horman
2011-05-27 17:40 ` David Miller
2011-05-27 17:42 ` Neil Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).