From: David Miller <davem@davemloft.net>
To: mingo@elte.hu
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 3/3] net: Kill ratelimit.h dependency in linux/net.h
Date: Fri, 27 May 2011 13:42:04 -0400 (EDT) [thread overview]
Message-ID: <20110527.134204.174469626330626704.davem@davemloft.net> (raw)
In-Reply-To: <20110527084403.GD21386@elte.hu>
From: Ingo Molnar <mingo@elte.hu>
Date: Fri, 27 May 2011 10:44:03 +0200
>> diff --git a/include/linux/net.h b/include/linux/net.h
>> index 1da55e9..b299230 100644
>> --- a/include/linux/net.h
>> +++ b/include/linux/net.h
>> @@ -289,11 +289,5 @@ extern int kernel_sock_shutdown(struct socket *sock,
>> MODULE_ALIAS("net-pf-" __stringify(pf) "-proto-" __stringify(proto) \
>> "-type-" __stringify(type))
>>
>> -#ifdef CONFIG_SYSCTL
>> -#include <linux/sysctl.h>
>> -#include <linux/ratelimit.h>
>> -extern struct ratelimit_state net_ratelimit_state;
>> -#endif
>> -
>
> Assuming that this moved into net_ratelimit.h with a guard define
> this looks good to me:
>
> Acked-by: Ingo Molnar <mingo@elte.hu>
Yep, thanks for reviewing!
prev parent reply other threads:[~2011-05-27 17:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-26 20:43 [PATCH 3/3] net: Kill ratelimit.h dependency in linux/net.h David Miller
2011-05-26 21:24 ` Joe Perches
2011-05-27 2:40 ` David Miller
2011-05-27 8:44 ` Ingo Molnar
2011-05-27 17:42 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110527.134204.174469626330626704.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).