From: Simon Horman <horms@verge.net.au>
To: Jesper Juhl <jj@chaosbits.net>
Cc: linux-kernel@vger.kernel.org, netfilter@vger.kernel.org,
coreteam@netfilter.org, netfilter-devel@vger.kernel.org,
lvs-devel@vger.kernel.org, netdev@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Patrick McHardy <kaber@trash.net>, Julian Anastasov <ja@ssi.bg>,
Wensong Zhang <wensong@linux-vs.org>,
Pablo Neira Ayuso <pablo@netfilter.org>
Subject: Re: [PATCH] netfilter, ipvs: Avoid undefined order of evaluation in assignments to struct nf_conn *
Date: Mon, 30 May 2011 08:23:37 +0900 [thread overview]
Message-ID: <20110529232337.GD5856@verge.net.au> (raw)
In-Reply-To: <alpine.LNX.2.00.1105292011450.4411@swampdragon.chaosbits.net>
On Sun, May 29, 2011 at 08:22:56PM +0200, Jesper Juhl wrote:
> In net/netfilter/ipvs/ip_vs_nfct.c::ip_vs_update_conntrack(),
> net/netfilter/ipvs/ip_vs_xmit.c::ip_vs_nat_xmit(),
> net/netfilter/ipvs/ip_vs_xmit.c::ip_vs_nat_xmit_v6(),
> net/netfilter/ipvs/ip_vs_xmit.c::ip_vs_icmp_xmit)()
> net/netfilter/ipvs/ip_vs_xmit.c::and ip_vs_icmp_xmit_v6() we do this:
> ...
> struct nf_conn *ct = ct = nf_ct_get(skb, &ctinfo);
> ...
>
> Since '=' is not a sequence point the order of these assignments happening
> is undefined. Luckily it's easy to avoid by just doing what is obviously
> the intended thing:
> struct nf_conn *ct = nf_ct_get(skb, &ctinfo);
>
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Acked-by: Simon Horman <horms@verge.net.au>
next prev parent reply other threads:[~2011-05-29 23:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-29 18:22 [PATCH] netfilter, ipvs: Avoid undefined order of evaluation in assignments to struct nf_conn * Jesper Juhl
2011-05-29 23:23 ` Simon Horman [this message]
2011-06-02 12:59 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110529232337.GD5856@verge.net.au \
--to=horms@verge.net.au \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=ja@ssi.bg \
--cc=jj@chaosbits.net \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lvs-devel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=netfilter@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=wensong@linux-vs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).