From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH 7/10] drivers/net/davinci_emac.c: add missing clk_put
Date: Wed, 01 Jun 2011 21:20:36 -0700 (PDT)
Message-ID: <20110601.212036.1247786739427089909.davem@davemloft.net>
References: <1306948213-20767-7-git-send-email-julia@diku.dk>
	<1306957764.26236.37.camel@vence>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: julia@diku.dk, kernel-janitors@vger.kernel.org, cyril@ti.com,
	srk@ti.com, weil@mail.berlios.de, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
To: khilman@ti.com
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <1306957764.26236.37.camel@vence>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: netdev.vger.kernel.org

From: Kevin Hilman <khilman@ti.com>
Date: Wed, 01 Jun 2011 12:49:24 -0700

> On Wed, 2011-06-01 at 19:10 +0200, Julia Lawall wrote:
>> From: Julia Lawall <julia@diku.dk>
>> 
>> Go to existing error handling code at the end of the function that calls
>> clk_put.
>> 
>> A simplified version of the semantic match that finds this problem is as
>> follows: (http://coccinelle.lip6.fr/)
>> 
>> // <smpl>
>> @r exists@
>> expression e1,e2;
>> statement S;
>> @@
>> 
>> e1 = clk_get@p1(...);
>> ... when != e1 = e2
>>     when != clk_put(e1)
>>     when any
>> if (...) { ... when != clk_put(e1)
>>                when != if (...) { ... clk_put(e1) ... }
>> * return@p3 ...;
>>  } else S
>> // </smpl>
>> 
>> Signed-off-by: Julia Lawall <julia@diku.dk>
> 
> Acked-by: Kevin Hilman <khilman@ti.com>

Applied, thanks.