netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Frank Blaschka <blaschka@linux.vnet.ibm.com>
To: davem@davemloft.net, eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, linux-s390@vger.kernel.org,
	heiko.carstens@de.ibm.com
Subject: [BUG] net: cpu offline cause napi stall
Date: Wed, 1 Jun 2011 12:33:56 +0200	[thread overview]
Message-ID: <20110601103356.GA45482@tuxmaker.boeblingen.de.ibm.com> (raw)

Hi Dave, Eric,

during heavy network load we turn off/on cpus.
Sometimes this causes a stall on the network device.
Digging into the dump I found out following:

napi is scheduled but does not run. From the I/O buffers
and the napi state I see napi/rx_softirq processing has stopped
because the budget was reached. napi stays in the
softnet_data poll_list and the rx_softirq was raised again.

I assume at this time the cpu offline comes in.
the rx softirq is raised/moved to another cpu but napi stays in the poll_list
of the softnet_data of the now offline cpu.

reviewing dev_cpu_callback (net/core/dev.c) I did not find the poll_list
is transfered to the new cpu. Do you think this could cause the stall or
did I miss something?

Thx for your help.

Frank


             reply	other threads:[~2011-06-01 10:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-01 10:33 Frank Blaschka [this message]
2011-06-01 12:13 ` [BUG] net: cpu offline cause napi stall Eric Dumazet
2011-06-01 16:36   ` Heiko Carstens
2011-06-01 16:55     ` Eric Dumazet
2011-06-01 18:12       ` Heiko Carstens
2011-06-01 20:03         ` Eric Dumazet
2011-06-01 20:42           ` Heiko Carstens
2011-06-06 21:50             ` David Miller
2011-06-07  6:50               ` [PATCH] " Eric Dumazet
2011-06-07  7:09                 ` Eric Dumazet
2011-06-07  8:01                 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110601103356.GA45482@tuxmaker.boeblingen.de.ibm.com \
    --to=blaschka@linux.vnet.ibm.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=heiko.carstens@de.ibm.com \
    --cc=linux-s390@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).