From: "Matt Carlson" <mcarlson@broadcom.com>
To: "Meelis Roos" <mroos@ut.ee>
Cc: "Matthew Carlson" <mcarlson@broadcom.com>,
"Michael Chan" <mchan@broadcom.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH] Add Fujitsu 1000base-SX PCI ID to tg3
Date: Wed, 1 Jun 2011 14:14:01 -0700 [thread overview]
Message-ID: <20110601211401.GB1482@mcarlson.broadcom.com> (raw)
In-Reply-To: <alpine.SOC.1.00.1105251836550.16961@math.ut.ee>
On Wed, May 25, 2011 at 08:43:47AM -0700, Meelis Roos wrote:
> This patch adds the PCI ID of Fujitsu 1000base-SX NIC to tg3 driver.
> Tested to detect the card, MAC and serdes, not tested with link at the
> moment since I have no fiber switch here. I did not add new constants to
> the pci_ids.h header file since these constants are used only here.
>
> Signed-off-by: Meelis Roos <mroos@linux.ee>
>
> diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
> index 7a5daef..7b1901e 100644
> --- a/drivers/net/tg3.c
> +++ b/drivers/net/tg3.c
> @@ -273,6 +273,7 @@ static DEFINE_PCI_DEVICE_TABLE(tg3_pci_tbl) = {
> {PCI_DEVICE(PCI_VENDOR_ID_ALTIMA, PCI_DEVICE_ID_ALTIMA_AC1003)},
> {PCI_DEVICE(PCI_VENDOR_ID_ALTIMA, PCI_DEVICE_ID_ALTIMA_AC9100)},
> {PCI_DEVICE(PCI_VENDOR_ID_APPLE, PCI_DEVICE_ID_APPLE_TIGON3)},
> + {PCI_DEVICE(0x10cf, 0x11a2)}, /* Fujitsu 1000base-SX with BCM5703SKHB */
> {}
> };
I don't have any problems with the patch, but before we integrate it,
can we make sure it passes traffic? I'd hate to add support for a
device and later find out it doesn't work.
next prev parent reply other threads:[~2011-06-01 21:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-25 15:43 [PATCH] Add Fujitsu 1000base-SX PCI ID to tg3 Meelis Roos
2011-06-01 21:14 ` Matt Carlson [this message]
2011-06-02 12:35 ` Meelis Roos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110601211401.GB1482@mcarlson.broadcom.com \
--to=mcarlson@broadcom.com \
--cc=mchan@broadcom.com \
--cc=mroos@ut.ee \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox