From: David Miller <davem@davemloft.net>
To: nicolas.2p.debian@gmail.com
Cc: nhorman@tuxdriver.com, bhutchings@solarflare.com,
netdev@vger.kernel.org, fubar@us.ibm.com, andy@greyhouse.net
Subject: Re: [PATCH] bonding: reset queue mapping prior to transmission to physical device
Date: Thu, 02 Jun 2011 13:46:37 -0700 (PDT) [thread overview]
Message-ID: <20110602.134637.1101638217263464114.davem@davemloft.net> (raw)
In-Reply-To: <4DE7EF05.8030505@gmail.com>
From: Nicolas de Pesloüan <nicolas.2p.debian@gmail.com>
Date: Thu, 02 Jun 2011 22:13:57 +0200
> To be more precise, due to the way bonding use queue mapping for slave
> selection, it is desirable to clear the mapping before sending to the
> slave, because the meaning of the mapping for the slave interface
> might be really different from the meaning for the bonding
> interface. Arguably, this is the mapping usage in bonding which is
> "different" from other usages, but...
This just confirms my reasoning behind why I wanted to discourage
drivers from providing explicit ->ndo_select_queue() methods unless
absolutely necessary.
Information now gets lost in cases like this bonding issue.
Bonding should definitely, as I suggested, remember the original
rxhash value and restore it when sending to the slave.
next prev parent reply other threads:[~2011-06-02 20:47 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-02 18:03 [PATCH] bonding: reset queue mapping prior to transmission to physical device Neil Horman
2011-06-02 18:35 ` Ben Hutchings
2011-06-02 18:56 ` Neil Horman
2011-06-02 19:09 ` Ben Hutchings
2011-06-02 19:46 ` Neil Horman
2011-06-02 19:52 ` Nicolas de Pesloüan
2011-06-02 20:04 ` David Miller
2011-06-02 20:13 ` Nicolas de Pesloüan
2011-06-02 20:46 ` David Miller [this message]
2011-06-02 20:51 ` Ben Hutchings
2011-06-02 21:10 ` David Miller
2011-06-02 20:13 ` Ben Hutchings
2011-06-03 1:16 ` Neil Horman
2011-06-02 19:59 ` David Miller
2011-06-02 20:07 ` David Miller
2011-06-02 20:22 ` Nicolas de Pesloüan
2011-06-03 1:04 ` Neil Horman
2011-06-03 13:26 ` [PATCH] bonding: reset queue mapping prior to transmission to physical device (v2) Neil Horman
2011-06-03 14:43 ` Ben Hutchings
2011-06-03 17:32 ` [PATCH] bonding: reset queue mapping prior to transmission to physical device (v3) Neil Horman
2011-06-03 17:59 ` Ben Hutchings
2011-06-03 18:36 ` Neil Horman
2011-06-03 19:12 ` Ben Hutchings
2011-06-03 19:23 ` Neil Horman
2011-06-03 19:24 ` [PATCH] bonding: reset queue mapping prior to transmission to physical device (v4) Neil Horman
2011-06-03 19:48 ` Eric Dumazet
2011-06-03 19:57 ` Neil Horman
2011-06-03 20:05 ` Eric Dumazet
2011-06-03 20:35 ` [PATCH] bonding: reset queue mapping prior to transmission to physical device (v5) Neil Horman
2011-06-03 23:31 ` Jay Vosburgh
2011-06-05 21:32 ` David Miller
2011-06-03 18:06 ` [PATCH] bonding: reset queue mapping prior to transmission to physical device (v3) Jay Vosburgh
2011-06-03 14:59 ` [PATCH] bonding: reset queue mapping prior to transmission to physical device (v2) Vitalii Demianets
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110602.134637.1101638217263464114.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andy@greyhouse.net \
--cc=bhutchings@solarflare.com \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=nicolas.2p.debian@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).