Netdev List
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Mika Westerberg <mika.westerberg@iki.fi>
Cc: netdev@vger.kernel.org, hsweeten@visionengravers.com,
	ryan@bluewatersys.com, kernel@wantstofly.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/5] net: ep93xx_eth: pass struct device to DMA API functions
Date: Thu, 2 Jun 2011 10:52:24 +0100	[thread overview]
Message-ID: <20110602095224.GT3660@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <89df467f9811b4f869513de3ada90ce7de74c6d1.1307006502.git.mika.westerberg@iki.fi>

On Thu, Jun 02, 2011 at 12:38:13PM +0300, Mika Westerberg wrote:
> We shouldn't use NULL for any DMA API functions, unless we are dealing with
> ISA or EISA device. So pass correct struct dev pointer to these functions.

Thanks for doing this - it certainly makes things more correct, even
if the original problem has been resolved by the troublesome GFP_DMA
commit having been reverted.  As such I think this patch series should
still be applied.

I think the series should be re-ordered so that patch 5 is first however,
as you can do that with or without the remainder of the patches.

For the entire series:

Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>

      parent reply	other threads:[~2011-06-02  9:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-02  9:38 [PATCH 1/5] net: ep93xx_eth: pass struct device to DMA API functions Mika Westerberg
2011-06-02  9:38 ` [PATCH 2/5] net: ep93xx_eth: allocate buffers using kmalloc() Mika Westerberg
2011-06-02  9:38 ` [PATCH 3/5] net: ep93xx_eth: drop GFP_DMA from call to dma_alloc_coherent() Mika Westerberg
2011-06-02  9:38 ` [PATCH 4/5] net: ep93xx_eth: fix DMA API violations Mika Westerberg
2011-06-02  9:38 ` [PATCH 5/5] ep93xx: set DMA masks for the ep93xx_eth Mika Westerberg
2011-06-02  9:52 ` Russell King - ARM Linux [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110602095224.GT3660@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=hsweeten@visionengravers.com \
    --cc=kernel@wantstofly.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=mika.westerberg@iki.fi \
    --cc=netdev@vger.kernel.org \
    --cc=ryan@bluewatersys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox