* [PATCHv2 NEXT 1/1] netxen: suppress false lro warning messages
@ 2011-06-02 12:24 amit.salecha
2011-06-03 7:03 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: amit.salecha @ 2011-06-02 12:24 UTC (permalink / raw)
To: davem
Cc: netdev, ameen.rahman, anirban.chakraborty, Sucheta Chakraborty,
Amit Kumar Salecha
From: Sucheta Chakraborty <sucheta.chakraborty@qlogic.com>
When interface is down, driver prints false warning messages
during lro configuration through ethtool.
Signed-off-by: Sucheta Chakraborty <sucheta.chakraborty@qlogic.com>
Signed-off-by: Amit Kumar Salecha <amit.salecha@qlogic.com>
---
drivers/net/netxen/netxen_nic_hw.c | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/drivers/net/netxen/netxen_nic_hw.c b/drivers/net/netxen/netxen_nic_hw.c
index 5cef718..3f89e57 100644
--- a/drivers/net/netxen/netxen_nic_hw.c
+++ b/drivers/net/netxen/netxen_nic_hw.c
@@ -809,6 +809,9 @@ int netxen_config_hw_lro(struct netxen_adapter *adapter, int enable)
u64 word;
int rv = 0;
+ if (!test_bit(__NX_FW_ATTACHED, &adapter->state))
+ return 0;
+
memset(&req, 0, sizeof(nx_nic_req_t));
req.qhdr = cpu_to_le64(NX_HOST_REQUEST << 23);
@@ -959,6 +962,9 @@ int netxen_send_lro_cleanup(struct netxen_adapter *adapter)
u64 word;
int rv;
+ if (!test_bit(__NX_FW_ATTACHED, &adapter->state))
+ return 0;
+
memset(&req, 0, sizeof(nx_nic_req_t));
req.qhdr = cpu_to_le64(NX_HOST_REQUEST << 23);
--
1.7.3.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCHv2 NEXT 1/1] netxen: suppress false lro warning messages
2011-06-02 12:24 [PATCHv2 NEXT 1/1] netxen: suppress false lro warning messages amit.salecha
@ 2011-06-03 7:03 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2011-06-03 7:03 UTC (permalink / raw)
To: amit.salecha
Cc: netdev, ameen.rahman, anirban.chakraborty, sucheta.chakraborty
From: amit.salecha@qlogic.com
Date: Thu, 2 Jun 2011 05:24:14 -0700
> From: Sucheta Chakraborty <sucheta.chakraborty@qlogic.com>
>
> When interface is down, driver prints false warning messages
> during lro configuration through ethtool.
>
> Signed-off-by: Sucheta Chakraborty <sucheta.chakraborty@qlogic.com>
> Signed-off-by: Amit Kumar Salecha <amit.salecha@qlogic.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-06-03 7:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-02 12:24 [PATCHv2 NEXT 1/1] netxen: suppress false lro warning messages amit.salecha
2011-06-03 7:03 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).