From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCHv3] net: Define enum for the bits used in features.
Date: Mon, 06 Jun 2011 12:20:59 -0700 (PDT)
Message-ID: <20110606.122059.261517215690508151.davem@davemloft.net>
References: <20110606035808.GA28858@redhat.com>
	<20110605.221537.899061768025493519.davem@davemloft.net>
	<20110606153253.GB30665@redhat.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: maheshb@google.com, netdev@vger.kernel.org, therbert@google.com,
	mirqus@gmail.com, shemminger@vyatta.com
To: mst@redhat.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([198.137.202.13]:57352 "EHLO
	shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1757855Ab1FFTVM (ORCPT
	<rfc822;netdev@vger.kernel.org>); Mon, 6 Jun 2011 15:21:12 -0400
In-Reply-To: <20110606153253.GB30665@redhat.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: "Michael S. Tsirkin" <mst@redhat.com>
Date: Mon, 6 Jun 2011 18:32:53 +0300

> On Sun, Jun 05, 2011 at 10:15:37PM -0700, David Miller wrote:
>> Since the GSO accessors deal with mutliple bits, you can create
>> special GSO specific interfaces to manipulate them.
> 
> Yes but it's not just GSO.
> It's anything that includes more than 1 feature.
> Examples:
> NETIF_F_ALL_CSUM
> NETIF_F_ALL_TX_OFFLOADS
> NETIF_F_V6_CSUM
> NETIF_F_SOFT_FEATURES
> 
> etc
> 
> Creating many accessors for each will need a lot
> of code duplication ...

Yet this is something you must resolve in order to change the feature
bit implementation.

Whether this issue is difficult or not to address, it has to be done
either way.