netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev <netdev@vger.kernel.org>
Subject: Re: [RFC] should we care of COMPAT mode in bridge ?
Date: Mon, 6 Jun 2011 22:06:28 +0200	[thread overview]
Message-ID: <201106062206.29134.arnd@arndb.de> (raw)
In-Reply-To: <1307389540.2642.3.camel@edumazet-laptop>

On Monday 06 June 2011 21:45:40 Eric Dumazet wrote:
> While trying Alexander Holler patch, I found a 32bit brctl program was
> not able to work on a 64bit kernel. So I had to switch to another
> machine for my tests.
> 
> brctl addbr mybridge
> ->
> socket(PF_FILE, SOCK_STREAM, 0)         = 3
> ioctl(3, SIOCSIFBR, 0xffd509c0)         = -1 EINVAL (Invalid argument)
> 
> Should we care or not ?
> 

Generally, we try to make all ioctls work in compat mode. For the old
bridge ioctls, this is currently impossible because it uses SIOCPRIVATE
ioctls, but it would be easy to add an ndo_do_compat_ioctl. 

The solution that is documented in net/socket.c is to return 
an invalid version number for BRCTL_VERSION, in the hope that
brctl would switch to the newer interfaces. The new style bridge
ioctls (SIOCBRADDBR, SIOCBRADDIF, ...) are actually supposed to work,
but I've never tried that.

	Arnd

  parent reply	other threads:[~2011-06-06 20:06 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-06 19:45 [RFC] should we care of COMPAT mode in bridge ? Eric Dumazet
2011-06-06 20:03 ` David Miller
2011-06-06 20:23   ` Chris Friesen
2011-06-06 20:31     ` Arnd Bergmann
2011-06-06 20:31   ` Andreas Schwab
2011-06-06 20:34     ` Eric Dumazet
2011-06-07 23:51   ` Stephen Hemminger
2011-06-08  0:27     ` David Miller
2011-06-08 16:08       ` Stephen Hemminger
2011-06-06 20:06 ` Arnd Bergmann [this message]
2011-06-06 20:09   ` David Miller
2011-06-06 20:19     ` Arnd Bergmann
2011-06-06 20:23       ` David Miller
2011-06-07 23:54         ` Stephen Hemminger
2011-06-06 20:12   ` Eric Dumazet
2011-06-06 20:26     ` Arnd Bergmann
2011-06-06 20:32       ` Eric Dumazet
2011-06-06 20:33         ` Arnd Bergmann
2011-06-06 20:35           ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201106062206.29134.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).