From: Steffen Klassert <steffen.klassert@secunet.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>,
Herbert Xu <herbert@gondor.apana.org.au>,
netdev@vger.kernel.org
Subject: Re: [PATCH 2/3] ipv4: Fix packet size calculation for IPsec packets in __ip_append_data
Date: Wed, 8 Jun 2011 07:30:20 +0200 [thread overview]
Message-ID: <20110608053020.GA6489@secunet.com> (raw)
In-Reply-To: <1307423217.2642.59.camel@edumazet-laptop>
On Tue, Jun 07, 2011 at 07:06:57AM +0200, Eric Dumazet wrote:
>
> Nick mail was :
>
> http://www.spinics.net/lists/netdev/msg141308.html
>
Thanks for providing these informations.
> Unfortunatly I could not find on my machines where I put my own
> scripts...
>
> Not a big deal, I suspect we can revert my commit if you say it added a
> regression :)
>
In between I can confirm that we get the slowpath problem back with my
patch, so we still have a bug somewhere. Reverting your commit would
be just a band aid. I think it is better to find the bug and do a real
fix instead. Unfortunatly I fear I'm not able to track it down before
my vacation that starts tomorrow. I'll continue to work at it once I'm
back...
next prev parent reply other threads:[~2011-06-08 5:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-06 6:46 [PATCH 1/3] xfrm: Fix off by one in the replay advance functions Steffen Klassert
2011-06-06 6:48 ` [PATCH 2/3] ipv4: Fix packet size calculation for IPsec packets in __ip_append_data Steffen Klassert
2011-06-06 7:38 ` Eric Dumazet
2011-06-06 8:52 ` Steffen Klassert
2011-06-07 5:06 ` Eric Dumazet
2011-06-08 5:30 ` Steffen Klassert [this message]
2011-06-09 21:47 ` David Miller
2011-06-22 11:02 ` Steffen Klassert
2011-06-28 3:39 ` David Miller
2011-06-30 9:06 ` Steffen Klassert
2011-06-06 6:48 ` [PATCH 3/3] ipv4: Fix packet size calculation for raw " Steffen Klassert
2011-06-09 21:50 ` David Miller
2011-06-08 4:15 ` [PATCH 1/3] xfrm: Fix off by one in the replay advance functions David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110608053020.GA6489@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).