From: Greg KH <gregkh@suse.de>
To: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Joe Perches <joe@perches.com>,
Hank Janssen <hjanssen@microsoft.com>,
KY Srinivasan <kys@microsoft.com>,
"shemminger@vyatta.com" <shemminger@vyatta.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: Request for review on Hyper-V virtual network driver
Date: Thu, 9 Jun 2011 15:07:01 -0700 [thread overview]
Message-ID: <20110609220701.GA24006@suse.de> (raw)
In-Reply-To: <A1F3067C9B68744AA19F6802BAB8FFDC09603E8F@TK5EX14MBXC227.redmond.corp.microsoft.com>
On Thu, Jun 09, 2011 at 09:59:19PM +0000, Haiyang Zhang wrote:
> > -----Original Message-----
> > From: Joe Perches [mailto:joe@perches.com]
> > Sent: Thursday, June 09, 2011 5:39 PM
> > > create mode 100644 drivers/net/hyperv/netvsc.c
> > > create mode 100644 drivers/net/hyperv/netvsc_drv.c
> > > create mode 100644 drivers/net/hyperv/rndis_filter.c
> > > delete mode 100644 drivers/staging/hv/hyperv_net.h
> > > delete mode 100644 drivers/staging/hv/netvsc.c
> > > delete mode 100644 drivers/staging/hv/netvsc_drv.c
> > > delete mode 100644 drivers/staging/hv/rndis_filter.c
> >
> > I suggest you resend this using the -M or --find-renames option.
>
> Will do.
No, that will not show anything at all, which is the point of the
review. Otherwise it will just require someone to go look at the
drivers/staging/hv/ directory in linux-next to properly determine what
is happening here.
So this patch is fine for a review.
thanks,
greg k-h
next prev parent reply other threads:[~2011-06-09 22:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-09 21:27 Request for review on Hyper-V virtual network driver Haiyang Zhang
2011-06-09 21:38 ` Joe Perches
2011-06-09 21:59 ` Haiyang Zhang
2011-06-09 22:07 ` Greg KH [this message]
2011-06-09 22:16 ` Haiyang Zhang
2011-06-09 22:28 ` Joe Perches
2011-06-09 22:36 ` Haiyang Zhang
2011-06-09 22:49 ` Ben Hutchings
2011-06-09 22:56 ` Haiyang Zhang
2011-06-09 23:00 ` Greg KH
2011-06-09 21:56 ` Randy Dunlap
2011-06-09 22:00 ` Haiyang Zhang
[not found] <A1F3067C9B68744AA19F6802BAB8FFDC09603BC2@TK5EX14MBXC227.redmond.corp.microsoft.com>
2011-06-09 19:28 ` Greg KH
2011-06-09 19:32 ` Haiyang Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110609220701.GA24006@suse.de \
--to=gregkh@suse.de \
--cc=haiyangz@microsoft.com \
--cc=hjanssen@microsoft.com \
--cc=joe@perches.com \
--cc=kys@microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).