From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [PATCH v3] vlan: Fix the ingress VLAN_FLAG_REORDER_HDR check Date: Fri, 10 Jun 2011 14:12:43 +0200 Message-ID: <20110610121241.GE17568@minipsycho.redhat.com> References: <20110605.141446.1838641439880246155.davem@davemloft.net> <20110610083539.GB17568@minipsycho.redhat.com> <20110610093413.GC17568@minipsycho.redhat.com> <20110610103503.GD17568@minipsycho.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: David Miller , pratnakarlx@gmail.com, ebiederm@xmission.com, shemminger@linux-foundation.org, greearb@candelatech.com, nicolas.2p.debian@gmail.com, netdev@vger.kernel.org, kaber@trash.net, fubar@us.ibm.com, eric.dumazet@gmail.com, andy@greyhouse.net, jesse@nicira.com To: Changli Gao Return-path: Received: from mx1.redhat.com ([209.132.183.28]:38383 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755652Ab1FJMN2 (ORCPT ); Fri, 10 Jun 2011 08:13:28 -0400 Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: Fri, Jun 10, 2011 at 01:20:29PM CEST, xiaosuo@gmail.com wrote: >On Fri, Jun 10, 2011 at 6:35 PM, Jiri Pirko wrote: >> Fri, Jun 10, 2011 at 11:49:27AM CEST, xiaosuo@gmail.com wrote: >>> >>>For hw-accel-vlan-rx, is the headroom for this header expansion >>>reserved? I don't think so. Thanks. >> >> But this wasn't done for hw-accel-vlan-rx previously right? So why don't >> check for hw-accel-vlan-rx and don do unreorder in that case? >> > >Yes, it wasn't done before. We want to make the behaviors of >hw-accel-vlan-rx and non-hw-accel-vlan-rx are the same. Is it your >original goal of your vlan-untag patch? You are correct. I just thought that since disabling reordering will be most likely removed in near future, non-hw-accel-vlan-rx reorder disable would not be needed. > >-- >Regards, >Changli Gao(xiaosuo@gmail.com)