* 3c503: fix broken IRQ autoprobing
@ 2011-06-12 19:40 Ondrej Zary
2011-06-12 21:45 ` Ben Hutchings
0 siblings, 1 reply; 3+ messages in thread
From: Ondrej Zary @ 2011-06-12 19:40 UTC (permalink / raw)
To: netdev; +Cc: Kernel development list
Fix broken IRQ autoprobing in 3c503 driver:
- improper IRQ freeing (does not free IRQs causes WARN)
- missing break when an working IRQ is found
The driver works with this patch.
Signed-off-by: Ondrej Zary <linux@rainbow-software.org>
--- linux-2.6.39-rc2-orig/drivers/net/3c503.c 2011-04-06 03:30:43.000000000 +0200
+++ linux-2.6.39-rc2/drivers/net/3c503.c 2011-06-12 21:29:47.000000000 +0200
@@ -412,7 +412,7 @@ el2_open(struct net_device *dev)
outb_p(0x04 << ((*irqp == 9) ? 2 : *irqp), E33G_IDCFR);
outb_p(0x00, E33G_IDCFR);
msleep(1);
- free_irq(*irqp, el2_probe_interrupt);
+ free_irq(*irqp, &seen);
if (!seen)
continue;
@@ -422,6 +422,7 @@ el2_open(struct net_device *dev)
continue;
if (retval < 0)
goto err_disable;
+ break;
} while (*++irqp);
if (*irqp == 0) {
--
Ondrej Zary
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: 3c503: fix broken IRQ autoprobing
2011-06-12 19:40 3c503: fix broken IRQ autoprobing Ondrej Zary
@ 2011-06-12 21:45 ` Ben Hutchings
2011-06-13 22:25 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Ben Hutchings @ 2011-06-12 21:45 UTC (permalink / raw)
To: Ondrej Zary; +Cc: netdev, Kernel development list
[-- Attachment #1: Type: text/plain, Size: 669 bytes --]
On Sun, 2011-06-12 at 21:40 +0200, Ondrej Zary wrote:
> Fix broken IRQ autoprobing in 3c503 driver:
> - improper IRQ freeing (does not free IRQs causes WARN)
> - missing break when an working IRQ is found
>
> The driver works with this patch.
I made a previous attempt to fix autoprobing (commit
b0cf4dfb7cd21556efd9a6a67edcba0840b4d98d), but didn't have any hardware
to test on. In the process I introduced these new bugs. Sorry about
that.
> Signed-off-by: Ondrej Zary <linux@rainbow-software.org>
[...]
Reviewed-by: Ben Hutchings <ben@decadent.org.uk>
Ben.
--
Ben Hutchings
Teamwork is essential - it allows you to blame someone else.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: 3c503: fix broken IRQ autoprobing
2011-06-12 21:45 ` Ben Hutchings
@ 2011-06-13 22:25 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2011-06-13 22:25 UTC (permalink / raw)
To: ben; +Cc: linux, netdev, linux-kernel
From: Ben Hutchings <ben@decadent.org.uk>
Date: Sun, 12 Jun 2011 17:45:11 -0400
> On Sun, 2011-06-12 at 21:40 +0200, Ondrej Zary wrote:
>> Fix broken IRQ autoprobing in 3c503 driver:
>> - improper IRQ freeing (does not free IRQs causes WARN)
>> - missing break when an working IRQ is found
>>
>> The driver works with this patch.
>
> I made a previous attempt to fix autoprobing (commit
> b0cf4dfb7cd21556efd9a6a67edcba0840b4d98d), but didn't have any hardware
> to test on. In the process I introduced these new bugs. Sorry about
> that.
>
>> Signed-off-by: Ondrej Zary <linux@rainbow-software.org>
> [...]
> Reviewed-by: Ben Hutchings <ben@decadent.org.uk>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-06-13 22:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-12 19:40 3c503: fix broken IRQ autoprobing Ondrej Zary
2011-06-12 21:45 ` Ben Hutchings
2011-06-13 22:25 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).