From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Greg Dietsche <gregory.dietsche@cuw.edu>
Cc: linville@tuxdriver.com, kernel-janitors@vger.kernel.org,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] iwlegacy: remove unreachable code
Date: Mon, 13 Jun 2011 16:39:23 +0200 [thread overview]
Message-ID: <20110613143922.GA8111@redhat.com> (raw)
In-Reply-To: <4DF61E7E.908@cuw.edu>
On Mon, Jun 13, 2011 at 09:28:14AM -0500, Greg Dietsche wrote:
> On 06/02/2011 09:06 PM, Greg Dietsche wrote:
> >return; at the end of the function is unecessary.
> >
> >Signed-off-by: Greg Dietsche<Gregory.Dietsche@cuw.edu>
> >---
> > drivers/net/wireless/iwlegacy/iwl-eeprom.c | 1 -
> > 1 files changed, 0 insertions(+), 1 deletions(-)
> >
> >diff --git a/drivers/net/wireless/iwlegacy/iwl-eeprom.c b/drivers/net/wireless/iwlegacy/iwl-eeprom.c
> >index cb346d1..5bf3f49 100644
> >--- a/drivers/net/wireless/iwlegacy/iwl-eeprom.c
> >+++ b/drivers/net/wireless/iwlegacy/iwl-eeprom.c
> >@@ -316,7 +316,6 @@ static void iwl_legacy_init_band_reference(const struct iwl_priv *priv,
> > break;
> > default:
> > BUG();
> >- return;
> > }
> > }
> >
>
> any comments/reviews/acks on this patch series?
All 5 patches are applied in wireless-testing tree.
Thanks
Stanislaw
prev parent reply other threads:[~2011-06-13 14:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-03 2:06 [PATCH 1/5] iwlegacy: remove unreachable code Greg Dietsche
2011-06-03 2:06 ` [PATCH 2/5] iwlegacy: remove unecessary if statement Greg Dietsche
2011-06-03 2:06 ` [PATCH 3/5] iwlegacy: return -EINVAL instead of -1 Greg Dietsche
2011-06-03 2:06 ` [PATCH 4/5] iwlegacy: propagate error return value Greg Dietsche
2011-06-03 2:06 ` [PATCH 5/5] iwlegacy: add missing null check Greg Dietsche
2011-06-03 3:07 ` Gustavo F. Padovan
2011-06-03 3:24 ` [PATCH 5/5 v2] " Greg Dietsche
2011-06-13 14:28 ` [PATCH 1/5] iwlegacy: remove unreachable code Greg Dietsche
2011-06-13 14:39 ` Stanislaw Gruszka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110613143922.GA8111@redhat.com \
--to=sgruszka@redhat.com \
--cc=gregory.dietsche@cuw.edu \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).