From: "Vlad Zolotarov" <vladz@broadcom.com>
To: "David Woodhouse" <dwmw2@infradead.org>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Eilon Greenstein" <eilong@broadcom.com>,
"Dmitry Kravkov" <dmitry@broadcom.com>,
"Yaniv Rosner" <yaniv.rosner@broadcom.com>
Subject: Re: [PATCH] linux-firmware: Add a new bnx2x FW 7.0.20.0
Date: Tue, 14 Jun 2011 13:10:16 +0300 [thread overview]
Message-ID: <201106141310.16440.vladz@broadcom.com> (raw)
In-Reply-To: <1308045859.3450.6.camel@i7.infradead.org>
On Tuesday 14 June 2011 13:04:18 David Woodhouse wrote:
> On Tue, 2011-06-14 at 12:57 +0300, Vlad Zolotarov wrote:
> >
> > What do u mean? I do have put the ihex files under the net-next kernel
> > tree at the regular location plus I updated the the kernel's
> > firmware/WHENCE and firmware/Makefile files and of course I ran a
> > functionality tests for the driver after all patches and with the new
> > firmware.
>
> Ah, there lies your problem.
>
> Never put new firmware into the kernel source tree. It doesn't belong
> there.
>
> In the linux-firmware tree we store the *binary* files, which go
> directly into /lib/firmware as-is.
Aha... Correct me if I got u wrong: to test it I need to manually copy the new .fw files into the /lib/firmware directory, install the clean net-next kernel with the driver that supports this new FW and it should work. Is it what u meant?
thanks,
vlad
>
>
next prev parent reply other threads:[~2011-06-14 10:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201106141241.40764.vladz@broadcom.com>
2011-06-14 9:48 ` [PATCH] linux-firmware: Add a new bnx2x FW 7.0.20.0 David Woodhouse
2011-06-14 9:57 ` Vlad Zolotarov
2011-06-14 10:04 ` David Woodhouse
2011-06-14 10:10 ` Vlad Zolotarov [this message]
2011-06-14 10:16 ` David Woodhouse
2011-06-14 10:53 ` Vlad Zolotarov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201106141310.16440.vladz@broadcom.com \
--to=vladz@broadcom.com \
--cc=dmitry@broadcom.com \
--cc=dwmw2@infradead.org \
--cc=eilong@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=yaniv.rosner@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox