From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Vlad Zolotarov" Subject: Re: [PATCH] linux-firmware: Add a new bnx2x FW 7.0.20.0 Date: Tue, 14 Jun 2011 13:10:16 +0300 Message-ID: <201106141310.16440.vladz@broadcom.com> References: <201106141241.40764.vladz@broadcom.com> <201106141257.40621.vladz@broadcom.com> <1308045859.3450.6.camel@i7.infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: "netdev@vger.kernel.org" , "Eilon Greenstein" , "Dmitry Kravkov" , "Yaniv Rosner" To: "David Woodhouse" Return-path: Received: from mms1.broadcom.com ([216.31.210.17]:3362 "EHLO mms1.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755916Ab1FNKLA (ORCPT ); Tue, 14 Jun 2011 06:11:00 -0400 In-Reply-To: <1308045859.3450.6.camel@i7.infradead.org> Sender: netdev-owner@vger.kernel.org List-ID: On Tuesday 14 June 2011 13:04:18 David Woodhouse wrote: > On Tue, 2011-06-14 at 12:57 +0300, Vlad Zolotarov wrote: > > > > What do u mean? I do have put the ihex files under the net-next kernel > > tree at the regular location plus I updated the the kernel's > > firmware/WHENCE and firmware/Makefile files and of course I ran a > > functionality tests for the driver after all patches and with the new > > firmware. > > Ah, there lies your problem. > > Never put new firmware into the kernel source tree. It doesn't belong > there. > > In the linux-firmware tree we store the *binary* files, which go > directly into /lib/firmware as-is. Aha... Correct me if I got u wrong: to test it I need to manually copy the new .fw files into the /lib/firmware directory, install the clean net-next kernel with the driver that supports this new FW and it should work. Is it what u meant? thanks, vlad > >