* Re: [PATCH] linux-firmware: Add a new bnx2x FW 7.0.20.0 [not found] <201106141241.40764.vladz@broadcom.com> @ 2011-06-14 9:48 ` David Woodhouse 2011-06-14 9:57 ` Vlad Zolotarov 0 siblings, 1 reply; 6+ messages in thread From: David Woodhouse @ 2011-06-14 9:48 UTC (permalink / raw) To: Vlad Zolotarov Cc: netdev@vger.kernel.org, Eilon Greenstein, Dmitry Kravkov, Yaniv Rosner On Tue, 2011-06-14 at 12:41 +0300, Vlad Zolotarov wrote: > > bnx2x/bnx2x-e1-7.0.20.0.fw.ihex |10075 +++++++++++++++++++++ > bnx2x/bnx2x-e1h-7.0.20.0.fw.ihex |10538 ++++++++++++++++++++++ > bnx2x/bnx2x-e2-7.0.20.0.fw.ihex |18190 ++++++++++++++++++++++++++++++++++++++ You haven't tested this, have you? Add the binary file, not an ihex version. -- dwmw2 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] linux-firmware: Add a new bnx2x FW 7.0.20.0 2011-06-14 9:48 ` [PATCH] linux-firmware: Add a new bnx2x FW 7.0.20.0 David Woodhouse @ 2011-06-14 9:57 ` Vlad Zolotarov 2011-06-14 10:04 ` David Woodhouse 0 siblings, 1 reply; 6+ messages in thread From: Vlad Zolotarov @ 2011-06-14 9:57 UTC (permalink / raw) To: David Woodhouse Cc: netdev@vger.kernel.org, Eilon Greenstein, Dmitry Kravkov, Yaniv Rosner On Tuesday 14 June 2011 12:48:06 David Woodhouse wrote: > On Tue, 2011-06-14 at 12:41 +0300, Vlad Zolotarov wrote: > > > > bnx2x/bnx2x-e1-7.0.20.0.fw.ihex |10075 +++++++++++++++++++++ > > bnx2x/bnx2x-e1h-7.0.20.0.fw.ihex |10538 ++++++++++++++++++++++ > > bnx2x/bnx2x-e2-7.0.20.0.fw.ihex |18190 ++++++++++++++++++++++++++++++++++++++ > > You haven't tested this, have you? What do u mean? I do have put the ihex files under the net-next kernel tree at the regular location plus I updated the the kernel's firmware/WHENCE and firmware/Makefile files and of course I ran a functionality tests for the driver after all patches and with the new firmware. If u meant the different sort of testing, pls., clarify. > > Add the binary file, not an ihex version. I'll resend the binary files. thanks, vlad > > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] linux-firmware: Add a new bnx2x FW 7.0.20.0 2011-06-14 9:57 ` Vlad Zolotarov @ 2011-06-14 10:04 ` David Woodhouse 2011-06-14 10:10 ` Vlad Zolotarov 0 siblings, 1 reply; 6+ messages in thread From: David Woodhouse @ 2011-06-14 10:04 UTC (permalink / raw) To: Vlad Zolotarov Cc: netdev@vger.kernel.org, Eilon Greenstein, Dmitry Kravkov, Yaniv Rosner On Tue, 2011-06-14 at 12:57 +0300, Vlad Zolotarov wrote: > > What do u mean? I do have put the ihex files under the net-next kernel > tree at the regular location plus I updated the the kernel's > firmware/WHENCE and firmware/Makefile files and of course I ran a > functionality tests for the driver after all patches and with the new > firmware. Ah, there lies your problem. Never put new firmware into the kernel source tree. It doesn't belong there. In the linux-firmware tree we store the *binary* files, which go directly into /lib/firmware as-is. -- dwmw2 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] linux-firmware: Add a new bnx2x FW 7.0.20.0 2011-06-14 10:04 ` David Woodhouse @ 2011-06-14 10:10 ` Vlad Zolotarov 2011-06-14 10:16 ` David Woodhouse 0 siblings, 1 reply; 6+ messages in thread From: Vlad Zolotarov @ 2011-06-14 10:10 UTC (permalink / raw) To: David Woodhouse Cc: netdev@vger.kernel.org, Eilon Greenstein, Dmitry Kravkov, Yaniv Rosner On Tuesday 14 June 2011 13:04:18 David Woodhouse wrote: > On Tue, 2011-06-14 at 12:57 +0300, Vlad Zolotarov wrote: > > > > What do u mean? I do have put the ihex files under the net-next kernel > > tree at the regular location plus I updated the the kernel's > > firmware/WHENCE and firmware/Makefile files and of course I ran a > > functionality tests for the driver after all patches and with the new > > firmware. > > Ah, there lies your problem. > > Never put new firmware into the kernel source tree. It doesn't belong > there. > > In the linux-firmware tree we store the *binary* files, which go > directly into /lib/firmware as-is. Aha... Correct me if I got u wrong: to test it I need to manually copy the new .fw files into the /lib/firmware directory, install the clean net-next kernel with the driver that supports this new FW and it should work. Is it what u meant? thanks, vlad > > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] linux-firmware: Add a new bnx2x FW 7.0.20.0 2011-06-14 10:10 ` Vlad Zolotarov @ 2011-06-14 10:16 ` David Woodhouse 2011-06-14 10:53 ` Vlad Zolotarov 0 siblings, 1 reply; 6+ messages in thread From: David Woodhouse @ 2011-06-14 10:16 UTC (permalink / raw) To: Vlad Zolotarov Cc: netdev@vger.kernel.org, Eilon Greenstein, Dmitry Kravkov, Yaniv Rosner On Tue, 2011-06-14 at 13:10 +0300, Vlad Zolotarov wrote: > > Aha... Correct me if I got u wrong: to test it I need to manually copy > the new .fw files into the /lib/firmware directory, install the clean > net-next kernel with the driver that supports this new FW and it > should work. Is it what u meant? Right. Imagine that you have checked out the linux-firmware.git repository directly into /lib/firmware, and nothing else has been written there. -- dwmw2 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] linux-firmware: Add a new bnx2x FW 7.0.20.0 2011-06-14 10:16 ` David Woodhouse @ 2011-06-14 10:53 ` Vlad Zolotarov 0 siblings, 0 replies; 6+ messages in thread From: Vlad Zolotarov @ 2011-06-14 10:53 UTC (permalink / raw) To: David Woodhouse Cc: netdev@vger.kernel.org, Eilon Greenstein, Dmitry Kravkov, Yaniv Rosner On Tuesday 14 June 2011 13:16:43 David Woodhouse wrote: > On Tue, 2011-06-14 at 13:10 +0300, Vlad Zolotarov wrote: > > > > Aha... Correct me if I got u wrong: to test it I need to manually copy > > the new .fw files into the /lib/firmware directory, install the clean > > net-next kernel with the driver that supports this new FW and it > > should work. Is it what u meant? > > Right. Imagine that you have checked out the linux-firmware.git > repository directly into /lib/firmware, and nothing else has been > written there. Got it. I checked it now and surprizingly it worked... ;) thanks, man. I'm resending u *binaries* ... > > ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-06-14 10:54 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <201106141241.40764.vladz@broadcom.com>
2011-06-14 9:48 ` [PATCH] linux-firmware: Add a new bnx2x FW 7.0.20.0 David Woodhouse
2011-06-14 9:57 ` Vlad Zolotarov
2011-06-14 10:04 ` David Woodhouse
2011-06-14 10:10 ` Vlad Zolotarov
2011-06-14 10:16 ` David Woodhouse
2011-06-14 10:53 ` Vlad Zolotarov
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox