[PATCH net-next 0/24] bnx2x: New FW and support for 578xx

[PATCH net-next 0/24] bnx2x: New FW and support for 578xx

[Vlad Zolotarov]

Dave, pls., consider applying this patch series.

This patch series introduce support for the new 578x0 chip series and
therefore includes new 7.0.20 FW:
	1) New LINK code.
	2) Absolutely new HSI that allows supporting different chips in more
consolidated way, which caused a significant changes in the driver code
including moving the HSI handling code into a spearate files (patches 11
and 12).

We also send the new FW files to David Woodhouse. It's the first time we
submit to the linux-firmware git so I hope we don't mess the things up: we
DO NOT patch firmware/WHENCE and firmware/Makefile files in our net-next
patches and we patch the WHENCE file in the linux-firmware patch. Dave,
pls., confirm if it's a correct procedure.

If it is, pls., note that the bnx2x driver will compile but won't work
until u integrate the new FW into the kernel tree.

You may alsofind these patches at our public site.
	net-next series at http://linux.broadcom.com/eilong/1.70.00-0/
	New FW at http://linux.broadcom.com/eilong/FW-7.0.20.0/
 
Thanks,
vlad

Re: [PATCH net-next 0/24] bnx2x: New FW and support for 578xx

[David Miller]

From: "Vlad Zolotarov" <vladz@broadcom.com>
Date: Tue, 14 Jun 2011 14:32:31 +0300

> We also send the new FW files to David Woodhouse. It's the first time we
> submit to the linux-firmware git so I hope we don't mess the things up: we
> DO NOT patch firmware/WHENCE and firmware/Makefile files in our net-next
> patches and we patch the WHENCE file in the linux-firmware patch. Dave,
> pls., confirm if it's a correct procedure.
> 
> If it is, pls., note that the bnx2x driver will compile but won't work
> until u integrate the new FW into the kernel tree.

David Woodhouse, what do you think we should do here?

I'm inclined to integrate the firmware into net-next-2.6 since this
is the only way to keep the driver working consistently.

Otherwise people won't be able to git bisect properly, and that sucks.

Re: [PATCH net-next 0/24] bnx2x: New FW and support for 578xx

[Vlad Zolotarov]

On Tuesday 14 June 2011 18:54:02 David Miller wrote:
> From: "Vlad Zolotarov" <vladz@broadcom.com>
> Date: Tue, 14 Jun 2011 14:32:31 +0300
> 
> > We also send the new FW files to David Woodhouse. It's the first time we
> > submit to the linux-firmware git so I hope we don't mess the things up:
> > we DO NOT patch firmware/WHENCE and firmware/Makefile files in our
> > net-next patches and we patch the WHENCE file in the linux-firmware
> > patch. Dave, pls., confirm if it's a correct procedure.
> > 
> > If it is, pls., note that the bnx2x driver will compile but won't work
> > until u integrate the new FW into the kernel tree.
> 
> David Woodhouse, what do you think we should do here?
> 
> I'm inclined to integrate the firmware into net-next-2.6 since this
> is the only way to keep the driver working consistently.
> 
> Otherwise people won't be able to git bisect properly, and that sucks.

Dave, as long as /lib/firmware contains all existing firmwares there should be 
no problems, isn't it?

thanks,
vlad

Re: [PATCH net-next 0/24] bnx2x: New FW and support for 578xx

[David Miller]

From: "Vlad Zolotarov" <vladz@broadcom.com>
Date: Tue, 14 Jun 2011 19:22:40 +0300

> On Tuesday 14 June 2011 18:54:02 David Miller wrote:
>> From: "Vlad Zolotarov" <vladz@broadcom.com>
>> Date: Tue, 14 Jun 2011 14:32:31 +0300
>> 
>> > We also send the new FW files to David Woodhouse. It's the first time we
>> > submit to the linux-firmware git so I hope we don't mess the things up:
>> > we DO NOT patch firmware/WHENCE and firmware/Makefile files in our
>> > net-next patches and we patch the WHENCE file in the linux-firmware
>> > patch. Dave, pls., confirm if it's a correct procedure.
>> > 
>> > If it is, pls., note that the bnx2x driver will compile but won't work
>> > until u integrate the new FW into the kernel tree.
>> 
>> David Woodhouse, what do you think we should do here?
>> 
>> I'm inclined to integrate the firmware into net-next-2.6 since this
>> is the only way to keep the driver working consistently.
>> 
>> Otherwise people won't be able to git bisect properly, and that sucks.
> 
> Dave, as long as /lib/firmware contains all existing firmwares there should be 
> no problems, isn't it?

You're saying above that the driver will compile but not work in net-next-2.6
until the FW is integrated, that's not acceptable, the tree must be fully
bisectable for people trying to track down bugs.

Which is it?

Re: [PATCH net-next 0/24] bnx2x: New FW and support for 578xx

[Michael Chan]

On Tue, 2011-06-14 at 10:32 -0700, David Miller wrote:
> From: "Vlad Zolotarov" <vladz@broadcom.com>
> Date: Tue, 14 Jun 2011 19:22:40 +0300
> 
> > On Tuesday 14 June 2011 18:54:02 David Miller wrote:
> >> From: "Vlad Zolotarov" <vladz@broadcom.com>
> >> Date: Tue, 14 Jun 2011 14:32:31 +0300
> >> 
> >> > We also send the new FW files to David Woodhouse. It's the first time we
> >> > submit to the linux-firmware git so I hope we don't mess the things up:
> >> > we DO NOT patch firmware/WHENCE and firmware/Makefile files in our
> >> > net-next patches and we patch the WHENCE file in the linux-firmware
> >> > patch. Dave, pls., confirm if it's a correct procedure.
> >> > 
> >> > If it is, pls., note that the bnx2x driver will compile but won't work
> >> > until u integrate the new FW into the kernel tree.
> >> 
> >> David Woodhouse, what do you think we should do here?
> >> 
> >> I'm inclined to integrate the firmware into net-next-2.6 since this
> >> is the only way to keep the driver working consistently.
> >> 
> >> Otherwise people won't be able to git bisect properly, and that sucks.
> > 
> > Dave, as long as /lib/firmware contains all existing firmwares there should be 
> > no problems, isn't it?
> 
> You're saying above that the driver will compile but not work in net-next-2.6
> until the FW is integrated, that's not acceptable, the tree must be fully
> bisectable for people trying to track down bugs.
> 
> Which is it?
> 

If the firmware is not integrated into net-next-2.6, the newly patched
driver won't work.  You get an error at run time saying the firmware is
not available.

When David Woodhouse integrates the firmware and a new firmware rpm is
made available for users, then the new driver will work.

Re: [PATCH net-next 0/24] bnx2x: New FW and support for 578xx

[David Miller]

From: "Michael Chan" <mchan@broadcom.com>
Date: Tue, 14 Jun 2011 10:35:53 -0700

> If the firmware is not integrated into net-next-2.6, the newly patched
> driver won't work.  You get an error at run time saying the firmware is
> not available.
> 
> When David Woodhouse integrates the firmware and a new firmware rpm is
> made available for users, then the new driver will work.

This is terrible.

Re: [PATCH net-next 0/24] bnx2x: New FW and support for 578xx

[Vladislav Zolotarov]

On 14 ביונ 2011, at 20:47, "David Miller" <davem@davemloft.net> wrote:

> From: "Michael Chan" <mchan@broadcom.com>
> Date: Tue, 14 Jun 2011 10:35:53 -0700
> 
>> If the firmware is not integrated into net-next-2.6, the newly patched
>> driver won't work.  You get an error at run time saying the firmware is
>> not available.
>> 
>> When David Woodhouse integrates the firmware and a new firmware rpm is
>> made available for users, then the new driver will work.
> 
> This is terrible.
> 
Another option is that the person that wills to run a bisect has to start with pulling the latest linux-firmware git, copying its contents into the /lib/firmware and then start a bisect. 

This requires some sync between Dave and David: David should always be the first to integrate a new FW and only then Dave should inegrate a driver patch series with the support for this new FW. The responsibility for the ordering should be on the driver owner: in our case, i shouldn't be sending a net-next patch series until the linux-firmware patch is applied.

It doesn't sound that terrible price for having a kernel tree clean from binaries blobs... ;)

Vlad

Re: [PATCH net-next 0/24] bnx2x: New FW and support for 578xx

[David Miller]

From: "Vladislav Zolotarov" <vladz@broadcom.com>
Date: Tue, 14 Jun 2011 11:32:04 -0700

> This requires some sync between Dave and David: David should always
> be the first to integrate a new FW and only then Dave should
> inegrate a driver patch series with the support for this new FW. The
> responsibility for the ordering should be on the driver owner: in
> our case, i shouldn't be sending a net-next patch series until the
> linux-firmware patch is applied.

Ok, then let's get this propagated into David's firmware tree.

Re: [PATCH net-next 0/24] bnx2x: New FW and support for 578xx

[David Woodhouse]

On Tue, 14 Jun 2011, David Miller wrote:

> Ok, then let's get this propagated into David's firmware tree.

If there's a git-binary patch in my mailbox that I can apply when I get 
home in a few hours, I'll do it immediately. Bwh also has access now, too.

-- 
dwmw2

Re: [PATCH net-next 0/24] bnx2x: New FW and support for 578xx

[David Woodhouse]

On Tue, 14 Jun 2011, David Miller wrote:

> > When David Woodhouse integrates the firmware and a new firmware rpm is
> > made available for users, then the new driver will work.

Tarballs are made daily, as soon as the firmware is submitted (which 
doesn't have to wait until the driver is patched). There is no issue with 
bisecting, because any ABI change in the firmware means a *new* firmware 
file which can be instslled in *parallel*.

> This is terrible.

Nonsense. It just means you want to be using an up-to-date copy of the 
firmware, which is hardly a problem.

-- 
dwmw2

Re: [PATCH net-next 0/24] bnx2x: New FW and support for 578xx

[Eric Dumazet]

Le mardi 14 juin 2011 à 11:54 -0400, David Miller a écrit :
> From: "Vlad Zolotarov" <vladz@broadcom.com>
> Date: Tue, 14 Jun 2011 14:32:31 +0300
> 
> > We also send the new FW files to David Woodhouse. It's the first time we
> > submit to the linux-firmware git so I hope we don't mess the things up: we
> > DO NOT patch firmware/WHENCE and firmware/Makefile files in our net-next
> > patches and we patch the WHENCE file in the linux-firmware patch. Dave,
> > pls., confirm if it's a correct procedure.
> > 
> > If it is, pls., note that the bnx2x driver will compile but won't work
> > until u integrate the new FW into the kernel tree.
> 
> David Woodhouse, what do you think we should do here?
> 
> I'm inclined to integrate the firmware into net-next-2.6 since this
> is the only way to keep the driver working consistently.
> 
> Otherwise people won't be able to git bisect properly, and that sucks.


Hmm, I probably missed something obvious, but my dev machine (one HPG6
blade in a distant datacenter) fails to init its bnx2x interfaces with
current net-next-2.6

Can't load firmware file bnx2x/bnx2x-e1h-7.0.23.0.fw

Re: [PATCH net-next 0/24] bnx2x: New FW and support for 578xx

[Eilon Greenstein]

On Mon, 2011-07-18 at 02:48 -0700, Eric Dumazet wrote:
> Le mardi 14 juin 2011 à 11:54 -0400, David Miller a écrit :
> > From: "Vlad Zolotarov" <vladz@broadcom.com>
> > Date: Tue, 14 Jun 2011 14:32:31 +0300
> > 
> > > We also send the new FW files to David Woodhouse. It's the first time we
> > > submit to the linux-firmware git so I hope we don't mess the things up: we
> > > DO NOT patch firmware/WHENCE and firmware/Makefile files in our net-next
> > > patches and we patch the WHENCE file in the linux-firmware patch. Dave,
> > > pls., confirm if it's a correct procedure.
> > > 
> > > If it is, pls., note that the bnx2x driver will compile but won't work
> > > until u integrate the new FW into the kernel tree.
> > 
> > David Woodhouse, what do you think we should do here?
> > 
> > I'm inclined to integrate the firmware into net-next-2.6 since this
> > is the only way to keep the driver working consistently.
> > 
> > Otherwise people won't be able to git bisect properly, and that sucks.
> 
> 
> Hmm, I probably missed something obvious, but my dev machine (one HPG6
> blade in a distant datacenter) fails to init its bnx2x interfaces with
> current net-next-2.6
> 
> Can't load firmware file bnx2x/bnx2x-e1h-7.0.23.0.fw

You are missing the FW git from
git://git.kernel.org/pub/scm/linux/kernel/git/dwmw2/linux-firmware.git

You need to get it separately since the FW is not part of the kernel git
now.

Regards,
Eilon

Re: [PATCH net-next 0/24] bnx2x: New FW and support for 578xx

[Eric Dumazet]

Le lundi 18 juillet 2011 à 12:55 +0300, Eilon Greenstein a écrit :
> On Mon, 2011-07-18 at 02:48 -0700, Eric Dumazet wrote:

> > 
> > Hmm, I probably missed something obvious, but my dev machine (one HPG6
> > blade in a distant datacenter) fails to init its bnx2x interfaces with
> > current net-next-2.6
> > 
> > Can't load firmware file bnx2x/bnx2x-e1h-7.0.23.0.fw
> 
> You are missing the FW git from
> git://git.kernel.org/pub/scm/linux/kernel/git/dwmw2/linux-firmware.git
> 
> You need to get it separately since the FW is not part of the kernel git
> now.

I knew it was obvious, thanks Eilon, this works better now !

Re: [PATCH net-next 0/24] bnx2x: New FW and support for 578xx

[David Miller]

From: "Vlad Zolotarov" <vladz@broadcom.com>
Date: Tue, 14 Jun 2011 14:32:31 +0300

> Dave, pls., consider applying this patch series.

Applied to net-next-2.6