* [PATCH] net: sh_eth: tidyup compile warrning
@ 2011-06-13 8:17 Kuninori Morimoto
2011-06-17 3:08 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Kuninori Morimoto @ 2011-06-13 8:17 UTC (permalink / raw)
To: David S. Miller; +Cc: Linux-Net, shimoda
This patch tidyup below warrning
${LINUX}/drivers/net/sh_eth.c:1773: warning:
'mdp' may be used uninitialized in this function
Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Signed-off-by: Kuninori Morimoto <morimoto.kuninori@renesas.com>
---
drivers/net/sh_eth.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/sh_eth.c b/drivers/net/sh_eth.c
index 8a72a97..96a629f 100644
--- a/drivers/net/sh_eth.c
+++ b/drivers/net/sh_eth.c
@@ -1770,7 +1770,7 @@ static int sh_eth_drv_probe(struct platform_device *pdev)
int ret, devno = 0;
struct resource *res;
struct net_device *ndev = NULL;
- struct sh_eth_private *mdp;
+ struct sh_eth_private *mdp = NULL;
struct sh_eth_plat_data *pd;
/* get base addr */
@@ -1888,7 +1888,7 @@ out_unregister:
out_release:
/* net_dev free */
- if (mdp->tsu_addr)
+ if (mdp && mdp->tsu_addr)
iounmap(mdp->tsu_addr);
if (ndev)
free_netdev(ndev);
--
1.7.4.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] net: sh_eth: tidyup compile warrning
2011-06-13 8:17 [PATCH] net: sh_eth: tidyup compile warrning Kuninori Morimoto
@ 2011-06-17 3:08 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2011-06-17 3:08 UTC (permalink / raw)
To: morimoto.kuninori; +Cc: netdev, yoshihiro.shimoda.uh
From: Kuninori Morimoto <morimoto.kuninori@renesas.com>
Date: Mon, 13 Jun 2011 17:17:09 +0900
> This patch tidyup below warrning
>
> ${LINUX}/drivers/net/sh_eth.c:1773: warning:
> 'mdp' may be used uninitialized in this function
>
> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> Signed-off-by: Kuninori Morimoto <morimoto.kuninori@renesas.com>
Please just move the mdp assignment right after alloc_netdev()
succeeds.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-06-17 3:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-13 8:17 [PATCH] net: sh_eth: tidyup compile warrning Kuninori Morimoto
2011-06-17 3:08 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).